Skip to content

Add the eighth telemetry event to the disclosure - #6

Merged
haotianx merged 1 commit into
mainfrom
haotian/telemetry-event-list
Sep 4, 2026
Merged

Add the eighth telemetry event to the disclosure#6
haotianx merged 1 commit into
mainfrom
haotian/telemetry-event-list

Conversation

@haotianx

@haotianx haotianx commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Why

The Network access section added in #5 lists seven telemetry events. There are eight — cli_skill_updated fires once per skill that greptile skills update actually updates, carrying the skill name, exactly like cli_skill_installed.

I built that list by grepping the vendored bundle for direct track() call sites. skills.ts:257 dispatches this one as (runtime.track ?? track)(...) so the runtime can be injected in tests, and the minified form of that doesn't match a direct-call pattern. Caught by review on greptilia#11315, where the same list was being added to the CLI's own README.

A disclosure section is only worth having if it's exhaustive — an incomplete one is arguably worse than none, since it reads as a complete accounting. That's the whole reason this matters more than "one missing item" suggests, and it's what Anthropic's directory review checks.

What changed

  • cli_skill_updated added to the event list.
  • The event-fields sentence now names the skill name as what the two skill events carry, rather than leaving it under "such as".
  • plugin.json → 1.2.2.

The vendored CLI bundle is unchanged at 3.5.0; this is documentation only.

Verification

grep -rn "cli_" tools/greptile-cli/src in greptilia finds exactly these eight, verified against source rather than the bundle this time.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WXoXLaJiK5rqS7Xk6rBQZf

The Network access section lists seven events. There are eight:
cli_skill_updated fires once per skill that `greptile skills update` actually
updates, carrying the skill name.

I built that list by grepping the vendored bundle for direct track() call
sites. skills.ts dispatches this one as `(runtime.track ?? track)(...)` so the
runtime can be injected in tests, and the minified form of that does not match
a direct-call pattern. Caught by review on the greptilia side, where the same
list was being added to the CLI's own README.

A disclosure section is only worth having if it is exhaustive, so this matters
more here than the count suggests.
@greptile-apps-staging

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

Safe to merge; no defects were found in the changed documentation or plugin metadata.

What we checked:

  • Validated the baseline telemetry capture with local HTTPS interception and confirmed no external telemetry was sent. T-Rex
  • Compared the intercepted lifecycle against the current bundled CLI and confirmed the eight documented events in plugins/greptile/README.md:88-97 matched the CLI inventory with all assertions passing. T-Rex
  • Validated plugin metadata and bundled CLI version, confirming both recorded and runtime versions are 3.5.0. T-Rex
  • Validated that the baseline capture showed old README lacked cli_skill_updated, while the current capture includes it, and that the inventories match exactly. T-Rex

Summary

  • This change updates the plugin telemetry disclosure to include cli_skill_updated, clarifies the fixed skill-name field used by skill telemetry events, and increments the plugin version to 1.2.2.
  • The bundled CLI telemetry flow was exercised with outbound telemetry intercepted locally. The documentation’s eight-event inventory matches the bundled CLI, and the captured anonymous blocked-review event contained only platform/runtime fields and a fixed reason, with no code, repository, branch, path, file, or review-content data. Plugin metadata JSON and the bundled CLI version were also confirmed consistent.

@haotianx
haotianx merged commit dac0d8c into main Sep 4, 2026
2 checks passed
@haotianx
haotianx deleted the haotian/telemetry-event-list branch September 4, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant