Add the eighth telemetry event to the disclosure - #6
Merged
Conversation
The Network access section lists seven events. There are eight: cli_skill_updated fires once per skill that `greptile skills update` actually updates, carrying the skill name. I built that list by grepping the vendored bundle for direct track() call sites. skills.ts dispatches this one as `(runtime.track ?? track)(...)` so the runtime can be injected in tests, and the minified form of that does not match a direct-call pattern. Caught by review on the greptilia side, where the same list was being added to the CLI's own README. A disclosure section is only worth having if it is exhaustive, so this matters more here than the count suggests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Network access section added in #5 lists seven telemetry events. There are eight —
cli_skill_updatedfires once per skill thatgreptile skills updateactually updates, carrying the skill name, exactly likecli_skill_installed.I built that list by grepping the vendored bundle for direct
track()call sites.skills.ts:257dispatches this one as(runtime.track ?? track)(...)so the runtime can be injected in tests, and the minified form of that doesn't match a direct-call pattern. Caught by review on greptilia#11315, where the same list was being added to the CLI's own README.A disclosure section is only worth having if it's exhaustive — an incomplete one is arguably worse than none, since it reads as a complete accounting. That's the whole reason this matters more than "one missing item" suggests, and it's what Anthropic's directory review checks.
What changed
cli_skill_updatedadded to the event list.plugin.json→ 1.2.2.The vendored CLI bundle is unchanged at 3.5.0; this is documentation only.
Verification
grep -rn "cli_" tools/greptile-cli/srcin greptilia finds exactly these eight, verified against source rather than the bundle this time.🤖 Generated with Claude Code
https://claude.ai/code/session_01WXoXLaJiK5rqS7Xk6rBQZf