fix(design-system): Add explicit type annotation for slots in DateRangePicker component - #200
Open
everettbu wants to merge 6 commits into
Open
fix(design-system): Add explicit type annotation for slots in DateRangePicker component#200everettbu wants to merge 6 commits into
everettbu wants to merge 6 commits into
Conversation
…gePicker component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of n8n-io/n8n#21188
Original author: samir0607
Summary
This PR fixes a TypeScript compiler complaint (TS7022) in the DateRangePicker component by adding an explicit type annotation for the slots variable.
What I changed:
In DateRangePicker.vue
Imported type Slots from vue.
Annotated slots as const slots: Slots = useSlots();.
Solves:
Status: Open.
#21187
Why:
TypeScript raised TS7022: "'slots' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer."
Adding the explicit Slots type restores proper typing for slots, improves IDE autocompletion, and prevents strict type-checking failures (for example under noImplicitAny).
Notes:
This change is low-risk and purely improves typing; no functional behavior was modified.
Unit tests for DateRangePicker are present and should continue passing.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)Note
Add explicit Vue
Slotstype forslotsinDateRangePicker.vueto resolve typing error.Written by Cursor Bugbot for commit e25e0ad. This will update automatically on new commits. Configure here.