Skip to content

fix: Remove stuck on MongoDB Chat Memory node #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
everettbu wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Remove stuck on MongoDB Chat Memory node #209

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42319de
Fix MongoClient initialization and error handling
adover134 Nov 5, 2025
e97da72
Merge branch 'n8n-io:master' into adover134-patch-3
adover134 Nov 5, 2025
22a479d
Merge branch 'master' into adover134-patch-3
adover134 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/@n8n/nodes-langchain/nodes/memory/MemoryMongoDbChat/MemoryMongoDbChat.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,9 @@ export class MemoryMongoDbChat implements INodeType {
);
}

let client: MongoClient|null=null;
try {
const client = new MongoClient(connectionString);
client=new MongoClient(connectionString);
await client.connect();

const db = client.db(dbName);
Expand All @@ -148,6 +149,9 @@ export class MemoryMongoDbChat implements INodeType {
outputKey: 'output',
k: this.getNodeParameter('contextWindowLength', itemIndex, 5) as number,
});

// wait for response before return
await memory.chatHistory.getMessages();

async function closeFunction() {
await client.close();
Expand All @@ -158,6 +162,10 @@ export class MemoryMongoDbChat implements INodeType {
response: logWrapper(memory, this),
};
} catch (error) {
try { // force to close client
await client.close();
} catch (error) {
}
throw new NodeOperationError(this.getNode(), `MongoDB connection error: ${error.message}`);
}
}
Expand Down