Fix Remove Duplicates node not showing new RSS items after first run - #301
Open
everettbu wants to merge 2 commits into
Open
Fix Remove Duplicates node not showing new RSS items after first run#301everettbu wants to merge 2 commits into
everettbu wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of n8n-io/n8n#22656
Original author: Mr-KRAMA
Problem
New RSS items were marked as processed during the same run
So on next run they looked like duplicates and were removed
Root Cause
In deduplication helper ts
New item hashes were added to processed data inside the loop
Solution
Collect all new item hashes first
Add them to processed data after the loop is complete
Result
New items show correctly on every run
Duplicate items still filtered
No breaking changes
Files Updated
deduplication helper ts and related tests