You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
supabase/supabase#40937 removed our gating on the feedback form (plus some related affordances) in an effort to concentrate support entry into the Help dropdown instead:
Before
After
Not applicable. This step is skipped in the new version.
Despite putting other measures in place such as client-side form detection, the result is that people are increasingly writing in to support via the Feedback form.
What is the new behavior?
Restores the gating
But also reuses the same self-debugging help options from the Help dropdown
Other:
Renames HelpPopover to HelpDropdown to match others
Adjusts font size of CommandMenuSearch...
Before
After
Not applicable. This step is skipped in the old version.
To test
To test the “thanks” end state, add something like the following to feedback-send.ts:
105 tests across 16 suites 7 minutes, 59 seconds 7ad1e15
Flaky tests
Features › cron-jobs.spec.ts › High Query Cost Banner › shows banner and still displays cron jobs when query cost exceeds threshold
Features › table-editor.spec.ts › table editor › can create and remove foreign key with column selection
Skipped tests
Features › assistant.spec.ts › AI Assistant › Can send a message to the assistant and receive a response
Features › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected
Features › sql-editor.spec.ts › SQL Editor › share with team works as expected
Features › sql-editor.spec.ts › SQL Editor › folders works as expected
Features › sql-editor.spec.ts › SQL Editor › other SQL snippets actions work as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of supabase/supabase#42548
Original author: dnywh
What kind of change does this PR introduce?
UI improvement for self-debugging efforts.
What is the current behavior?
supabase/supabase#40937 removed our gating on the feedback form (plus some related affordances) in an effort to concentrate support entry into the Help dropdown instead:
Despite putting other measures in place such as client-side form detection, the result is that people are increasingly writing in to support via the Feedback form.
What is the new behavior?
Other:
HelpPopovertoHelpDropdownto match othersCommandMenuSearch...To test
To test the “thanks” end state, add something like the following to
feedback-send.ts:Where
MOCK_FEEDBACK_SUCCESSistrue.Summary by CodeRabbit
Release Notes
New Features
Style