Skip to content

chore: Add credentials: omit when calling into /incident API endpoints#2443

Closed
everettbu wants to merge 1 commit into
masterfrom
fix/omit-credentials-incident
Closed

chore: Add credentials: omit when calling into /incident API endpoints#2443
everettbu wants to merge 1 commit into
masterfrom
fix/omit-credentials-incident

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of supabase/supabase#43777
Original author: ivasilov


/incident-status and /incident-banner are not cached because they include auth cookies which busts Vercel cache. This PR add credentials: omit since they calls don't need auth cookies and they're same for all users.

@blacksmith-sh

blacksmith-sh Bot commented Mar 14, 2026

Copy link
Copy Markdown
Contributor

Found 7 test failures on Blacksmith runners:

Failures

Test View Logs
[Features] › features/
realtime-inspector.spec.ts:115:5 › Realtime Inspector › Broadcast Messages › broadcast
modal validates JSON payload
View Logs
Realtime Inspector › Broadcast Messages/broadcast modal validates JSON payload View Logs
Realtime Inspector › Broadcast Messages/
broadcast modal validates JSON payload (retry #1)
View Logs
Realtime Inspector › Broadcast Messages/
broadcast modal validates JSON payload (retry #2)
View Logs
Realtime Inspector › Broadcast Messages/
broadcast modal validates JSON payload (retry #3)
View Logs
Realtime Inspector › Broadcast Messages/
broadcast modal validates JSON payload (retry #4)
View Logs
Realtime Inspector › Broadcast Messages/
broadcast modal validates JSON payload (retry #5)
View Logs

Fix in Cursor

@github-actions

Copy link
Copy Markdown
Contributor

🎭 Playwright Test Results

failed  1 failed
passed  155 passed
skipped  5 skipped

Details

stats  161 tests across 20 suites
duration  2 minutes, 19 seconds
commit  1382423

Failed tests

Features › realtime-inspector.spec.ts › Realtime Inspector › Broadcast Messages › broadcast modal validates JSON payload

Skipped tests

Features › assistant.spec.ts › AI Assistant › Can send a message to the assistant and receive a response
Features › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected
Features › sql-editor.spec.ts › SQL Editor › share with team works as expected
Features › sql-editor.spec.ts › SQL Editor › folders works as expected
Features › sql-editor.spec.ts › SQL Editor › other SQL snippets actions work as expected

@everettbu

Copy link
Copy Markdown
Author

Upstream PR was closed or merged. Code is synced via branch mirror.

@everettbu everettbu closed this Mar 14, 2026
@everettbu everettbu deleted the fix/omit-credentials-incident branch March 14, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants