Refactor deprecated components in Database Settings -> Network Restrictions modals#2490
Closed
everettbu wants to merge 3 commits into
Closed
Refactor deprecated components in Database Settings -> Network Restrictions modals#2490everettbu wants to merge 3 commits into
everettbu wants to merge 3 commits into
Conversation
Author
|
Upstream PR was closed or merged. Code is synced via branch mirror. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of supabase/supabase#38137
Original author: Saeris
Building on #38075 this PR consists of refactors specific to the Network Restrictions section modals for Allow All, Disallow All, Add Restriction and Remove Restriction
This should not be reviewed until #38075 is merged, since this is branched off from that PR. It'll remain in draft status until then.
Because three of these modals are merely confirmations, the logic driving them is virtually unchanged, however they now contain their triggers and check their own permissions in order to be self-contained.
For the Add Restriction modal, it has been updated to use
react-hook-formandzod, so the validation logic has been moved into a zod schema. It likely needs additional scrutiny out of the four refactored modals.