Add pagination to webhook deliveries table#2520
Draft
everettbu wants to merge 2 commits into
Draft
Conversation
Contributor
🎭 Playwright Test ResultsDetails
Skipped testsFeatures › assistant.spec.ts › AI Assistant › Can send a message to the assistant and receive a response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of supabase/supabase#43847
Original author: dnywh
What kind of change does this PR introduce?
Feature
What is the current behavior?
The webhook endpoint details view shows all mock deliveries in a single table without pagination or sortable columns, which makes it a poor fit for the Data Table direction this surface will need once real server-backed pagination and filtering land.
What is the new behavior?
Moves the deliveries table onto TanStack table state, adds sortable column headers, keeps the existing delivery search, and preserves simple previous/next pagination controls at the bottom. The mock deliveries are also expanded so pagination and sorting can be exercised in both organization and project flows.
Additional context
This keeps the view on the Data Table path now, so swapping client-side pagination for manual/server pagination later is a smaller follow-up instead of another structural rewrite.
Verification:
pnpm --filter studio exec vitest run components/interfaces/Platform/Webhooks/PlatformWebhooksEndpointDetails.test.tsx --coverage.enabled=falsepnpm typecheck