fix(studio): prompt on unsaved changes in foreign key selector#2555
Open
everettbu wants to merge 1 commit into
Open
fix(studio): prompt on unsaved changes in foreign key selector#2555everettbu wants to merge 1 commit into
everettbu wants to merge 1 commit into
Conversation
Contributor
🎭 Playwright Test ResultsDetails
Skipped testsFeatures › assistant.spec.ts › AI Assistant › Can send a message to the assistant and receive a response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of supabase/supabase#43888
Original author: dnywh
What kind of change does this PR introduce?
Bug fix. Resolves FE-2802. Fixes #43882.
What is the current behavior?
Second-level foreign key side panels in Table Editor can be dismissed while dirty without a discard confirmation. That makes accidental dismissal easy and is inconsistent with the shared dirty-form dismissal pattern from FE-2802.
What is the new behavior?
DiscardChangesConfirmationDialoghandling toForeignKeySelectormodality.mdxthat route-driven/page-unload flows should use a navigation guard rather than the dialog/sheet close guardAdditional context
Includes a focused unit test for foreign key dirty-state normalization.