Skip to content

fix(studio): correct password visibility toggle label on sign-up form ( 39399 )#307

Open
everettbu wants to merge 2 commits into
masterfrom
fix/issue-39399
Open

fix(studio): correct password visibility toggle label on sign-up form ( 39399 )#307
everettbu wants to merge 2 commits into
masterfrom
fix/issue-39399

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of supabase/supabase#40648
Original author: gauravjain-code


I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

Bug fix (UX/Accessibility): Corrects the password visibility toggle label on the Studio dashboard sign-up form.

What is the current behavior?

The password field’s eye icon on the sign-up form shows the wrong label:
When the password is hidden, the label reads “Hide password” (should be “Show password”).
When the password is visible, the label reads “Show password” (should be “Hide password”).
This occurs in:
[apps/studio/components/interfaces/SignIn/SignUpForm.tsx]
Related: Issue tagged “to-triage” reporting the inverted label on the sign-up form.

Please link any relevant issues here.

What is the new behavior?

The password visibility toggle now uses correct labels:
When the password is hidden, label/aria-label: “Show password”
When the password is visible, label/aria-label: “Hide password”
Implementation aligns SignUpForm with the already correct behavior in:
[apps/studio/components/interfaces/SignIn/SignInForm.tsx]
Code change (SignUpForm):
Swapped ternary strings for title and aria-label on the toggle Button.
Visual/UI impact: None to layout; tooltip/assistive text and screen reader output are corrected.

Additional context

File updated:
[apps/studio/components/interfaces/SignIn/SignUpForm.tsx]

Reference for correct behavior:
[apps/studio/components/interfaces/SignIn/SignInForm.tsx]
Validation steps:
Open [apps/studio/pages/sign-up.tsx] in the dashboard.
Focus the password field; hover the eye icon or inspect its aria-label.
Verify:
When masked, it reads “Show password”
After toggling to visible, it reads “Hide password”
Sanity-check sign-in page (already correct).
Scope:
Only the Studio sign-up form required changes.
No changes to UI library auth blocks or other password inputs.

Add any other context or screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants