block[speedtest]: Use networkquality-rs#2248
Open
bim9262 wants to merge 1 commit intogreshake:masterfrom
Open
Conversation
Collaborator
Author
|
@snaeil feel free to provide your feedback! |
|
@bim9262 I am not yet familiar with the repo but overall looks good to me. Since the commit message is almost conventional I would how you deal with breaking changes here and whether there's a need to make this clear somewhere |
Collaborator
Author
|
@snaeil , I assume you're refering to the addition of |
Collaborator
Author
|
I've reached out in cloudflare/networkquality-rs#38 to see if it's possible for the crates to be published to crates.io instead of pulling directly from github. |
The speedtest block was using speedtest-cli (https://github.com/sivel/speedtest-cli) which has been become archived and is no longer maintained. This commit replaces speedtest-cli with networkquality-rs (https://github.com/cloudflare/networkquality-rs). Resolves greshake#2245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The speedtest block was using speedtest-cli which has been become archived and is no longer maintained.
This commit replaces speedtest-cli with networkquality-rs.
Note that this requires
cmaketo be installed.I had to switch over to
rustlsas not doing so causes linking errors.The new version of
reqwestmoved torustls, so we'll move in that direction anyways.The nq crates are not published on crates.io so they are being checked out directly from github.
Resolves #2245