Skip to content

Create parent directories for local memory persistence #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
onyx679 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create parent directories for local memory persistence #2216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion griptape/drivers/memory/conversation/local_conversation_memory_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ class LocalConversationMemoryDriver(BaseConversationMemoryDriver):

def store(self, runs: list[Run], metadata: dict[str, Any]) -> None:
if self.persist_file is not None:
Path(self.persist_file).write_text(json.dumps(self._to_params_dict(runs, metadata)))
persist_file = Path(self.persist_file)
persist_file.parent.mkdir(parents=True, exist_ok=True)
persist_file.write_text(json.dumps(self._to_params_dict(runs, metadata)))

def load(self) -> tuple[list[Run], dict[str, Any]]:
if (
Expand Down
11 changes: 11 additions & 0 deletions tests/unit/drivers/memory/conversation/test_local_conversation_memory_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,17 @@ def test_store(self):

assert os.path.exists(self.MEMORY_FILE_PATH)

def test_store_creates_parent_directory(self, tmp_path):
persist_file = tmp_path / "memory" / self.MEMORY_FILE_PATH
memory_driver = LocalConversationMemoryDriver(persist_file=str(persist_file))
memory = ConversationMemory(conversation_memory_driver=memory_driver, autoload=False)
pipeline = Pipeline(conversation_memory=memory)

pipeline.add_task(PromptTask("test"))
pipeline.run()

assert persist_file.exists()

def test_load(self):
memory_driver = LocalConversationMemoryDriver(persist_file=self.MEMORY_FILE_PATH)
memory = ConversationMemory(
Expand Down
Loading