Switch app over to the 'modern' ways of auto-detecting middleware

[uberbrady]

So, this is allegedly the 'new' way that you're supposed to define your Middleware. I've been annoyed that, as we upgrade Laravel versions, we don't necessarily end up automagically getting the latest new Middleware stuff unless we add it in, by hand. For me, this just happened with the new Background Queue feature for Laravel. But I think @spencerrlongg got bit by this as well, when it came to something having to do with route-model-binding, maybe? So, I asked Claude to help me 'migrate' our middleware stacks and whatnot to whatever the 'modern' way is, and this is what it came up with.

It took a pretty conservative approach, which I think I'm mostly OK with - it notes its reasoning in the comments which all do make sense to me.

I have different changes to come that have to do with the Trusted Proxies headers, but those can be handled separately; this should be a true-ish translation of what-we-have-now into the 'modern' way, so that as we continue to upgrade Laravel versions, we should get whatever the newest middleware is supposed to be.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric	Results
Complexity	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[snipe]

Okay, so, I hate this a lot (not your fault - this time), but I also understand that this is The (modern Laravel) Way™. The ONE thing I might ask, at least for a few versions until I get used to the new location, is that we leave Kernel.php in the source, BUT just make it an almost-empty file with a just a PHP comment that points to the new location of the middleware loaders, etc. 13+ years of looking for them in the same places means I will 100% keep looking for the Kernel file and keep not understanding why I can't find it.

I won't block a merge on just that, but it would be really helpful for me personally. I know this will end up biting me. :(

[uberbrady]

There's some weirdness in here - I'll get that file added for you, for sure, but I also feel like the Middleware::withHeaders() is conflicting with the overrriden middleware we wrote. I'm going to try and sort that out.

[uberbrady]

Okay, I think I have this fixed up properly now - feel free to give it another look when you have a moment. It does pass tests.