CI: Switch to GitHub workflows and test Ruby 3.0 and 3.1#190
Merged
Conversation
Using `ends_with?` still works in Rails as they added it as an alias but make these specs fail on Ruby 2.7.5.
Contributor
Author
|
👋 @grosser Do you mind reviewing this PR? 🙏 Please bear with me as I am a GitHub workflow newbie 😅 |
b0a00fe to
daf2e54
Compare
We are testing on Ruby 2.7.5, 3.0 and 3.1 with Rails 5.2, 6.1 and 7.0. Ruby 3.x doesn't work with Rails 5.2.
Owner
|
FYI tiny cleanup #191 + helper to bundle all gemfiles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #189.
It:
end_with?hamitfor Ruby 1.9/2.0