Adds SQLCipher Custom Fork documentation#1853
Conversation
…on section to reference officially supported GRDB + SQLCipher fork and link SQLCipherCustomFork.md documentation.
|
Hello @R4N! Glad to see you again :-) This is a very valuable contribution! It can't be merged because of the reference to Do you think it is possible to reword this document and the README changes, and remove this reference? Also, based on the existing "Custom SQLite Builds" document, I suppose "Custom SQLCipher Builds" would be a better wording than "Custom SQLCipher Fork" (same for the name of the file). Thank you very much! |
…o official fork coming soon> with instructions for forking GRDB+SQLCipher using instructions in Package.swift within README.md and CustomSQLCipherBuilds doc.
|
@groue Great, Looks like the 7.10.0 release was well received! 🥳 I've replaced the reference to Good suggestion about the rename of the file/title of the document. That's also been adjusted now. |
|
Hi @R4N, Yes, v7.10.0 is welcome, we did a good work :-) I let you decide if you want to address #1854 before or after this pull request. If you want to address #1854 first, you might want to restore the URL of the official fork here. I let you decide your preferred option, and I'll follow your path. |
…tructions to reference officially supported GRDB + SQLCipher fork.
|
Excellent. Thanks! I did end up opening up the new fork first: https://github.com/sqlcipher/GRDB.swift so I've adjusted the documentation to link over to that in this pull request. |
|
Thank you both for doing this, I have a project using GRDB that's pulling in SQLCipher from a new SDK so this fork has been a blessing. Are there any plans to do the same for https://github.com/groue/GRDBSnapshotTesting? |
Adds SQLCipherCustomFork.md documentation. Adjusts README.md Encryption section to reference officially supported GRDB + SQLCipher fork and link SQLCipherCustomFork.md documentation.
This is a documentation update which includes instructions for creating a custom fork of GRDB w/SQLCipher to support requirements outside of the scope of the official fork.
Official Fork link has a placeholder of
<url to official fork coming soon>Pull Request Checklist
developmentbranch.make smokeTestterminal command runs without failure.