xds: move all functionality from xds/internal to internal/xds - #8515
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8515 +/- ##
==========================================
+ Coverage 81.82% 81.91% +0.09%
==========================================
Files 413 412 -1
Lines 40518 40518
==========================================
+ Hits 33153 33190 +37
+ Misses 5989 5937 -52
- Partials 1376 1391 +15
🚀 New features to boost your workflow:
|
easwars
changed the title
xds/internal to internal/xds in line wit…xds/internal to internal/xds
easwars
reviewed
Aug 15, 2025
easwars
left a comment
easwars
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just a few minor comments.
easwars
approved these changes
Aug 17, 2025
easwars
left a comment
easwars
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your contribution.
Contributor
|
Moving to @dfawley for a second set of eyes. |
dfawley
approved these changes
Aug 18, 2025
dfawley
left a comment
dfawley
left a comment
Member
There was a problem hiding this comment.
This is going to take a lot of getting used to...
Member
|
Could you please resolve the conflicts @CynicDog ? Thank you! |
…h the plan in grpc#7290, ensuring that only user-facing functionality remains in the top-level xds package. Updates all import paths and aliases to reference the new internal/xds package, using aliases (e.g., `internal` → `xds` or `xdsinternal`) where needed to minimize changes to call sites. No functional changes intended; this is purely a package path reorganization.
…test.go` Per code review feedback, consolidated the contents of internal/xds/internal.go into internal/xds/xds.go and internal/xds/internal_test.go into internal/xds/xds_test.go to keep related functionality in a single file and improve code organization.
CynicDog
force-pushed
the
move-xds-internal-to-internal-xds
branch
from
August 19, 2025 00:03
b9f518f to
05072c9
Compare
Contributor
Author
|
Hi @dfawley, conflicts are now resolved and the branch has been rebased on top of the latest master. Thanks! |
dimpavloff
pushed a commit
to dimpavloff/grpc-go
that referenced
this pull request
Aug 22, 2025
…pc#8515) Fixes grpc#7290, ensuring that only user-facing functionality remains in the top-level xds package. Updates all import paths and aliases to reference the new internal/xds package, using aliases (e.g., `internal` → `xds` or `xdsinternal`) where needed to minimize changes to call sites. No functional changes intended; this is purely a package path reorganization. RELEASE NOTES: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7290, ensuring that only user-facing functionality remains in the top-level xds package.
Updates all import paths and aliases to reference the new internal/xds package, using aliases (e.g.,
internal→xdsorxdsinternal) where needed to minimize changes to call sites.No functional changes intended; this is purely a package path reorganization.
RELEASE NOTES: none