Conversation
…ge and split scenarios
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8532 +/- ##
==========================================
+ Coverage 81.99% 82.03% +0.04%
==========================================
Files 412 412
Lines 40520 40450 -70
==========================================
- Hits 33225 33185 -40
+ Misses 5904 5887 -17
+ Partials 1391 1378 -13
🚀 New features to boost your workflow:
|
erenboz
commented
Aug 21, 2025
erenboz
force-pushed
the
priority_namegen_alternative
branch
from
August 22, 2025 10:43
12b972d to
18fd896
Compare
erenboz
force-pushed
the
priority_namegen_alternative
branch
from
August 22, 2025 10:45
18fd896 to
99b529f
Compare
erenboz
marked this pull request as draft
August 22, 2025 12:20
erenboz
commented
Aug 22, 2025
Contributor
|
Thanks for raising this change. In the grpc-go repo, we don't usually keep draft PRs. Since the discussion is going on in #8531, I'm closing this PR for the time being. I'll re-open this if we decide to go forward with this approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative implementation for #8531