Skip to content

xds/clusterresolver: [alternative] Revise configbuilder childname generator to fix leakage issues with merge and split scenarios - #8532

Closed
erenboz wants to merge 3 commits into
grpc:masterfrom
erenboz:priority_namegen_alternative
Closed

erenboz wants to merge 3 commits into
grpc:masterfrom
erenboz:priority_namegen_alternative

Conversation

@erenboz

@erenboz erenboz commented Aug 21, 2025

Copy link
Copy Markdown

Alternative implementation for #8531

@codecov

codecov Bot commented Aug 21, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.03%. Comparing base (5ed7cf6) to head (cec1bc6).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8532      +/-   ##
==========================================
+ Coverage   81.99%   82.03%   +0.04%     
==========================================
  Files         412      412              
  Lines       40520    40450      -70     
==========================================
- Hits        33225    33185      -40     
+ Misses       5904     5887      -17     
+ Partials     1391     1378      -13     
Files with missing lines Coverage Δ
...alancer/clusterresolver/configbuilder_childname.go 100.00% <100.00%> (ø)

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread internal/xds/balancer/clusterresolver/configbuilder_childname.go Outdated
@erenboz
erenboz force-pushed the priority_namegen_alternative branch from 12b972d to 18fd896 Compare August 22, 2025 10:43
@erenboz
erenboz force-pushed the priority_namegen_alternative branch from 18fd896 to 99b529f Compare August 22, 2025 10:45
@erenboz erenboz changed the title xds/clusterresolver: [alternative] Revise configbuilder childname generator to fix reuse issues with merge and split scenarios xds/clusterresolver: [wip:alternative] Revise configbuilder childname generator to fix reuse issues with merge and split scenarios Aug 22, 2025
@erenboz
erenboz marked this pull request as draft August 22, 2025 12:20
Comment thread internal/xds/balancer/clusterresolver/configbuilder_childname_test.go Outdated
@erenboz erenboz changed the title xds/clusterresolver: [wip:alternative] Revise configbuilder childname generator to fix reuse issues with merge and split scenarios xds/clusterresolver: [alternative] Revise configbuilder childname generator to fix leakage issues with merge and split scenarios Aug 24, 2025
@arjan-bal

Copy link
Copy Markdown
Contributor

Thanks for raising this change. In the grpc-go repo, we don't usually keep draft PRs. Since the discussion is going on in #8531, I'm closing this PR for the time being. I'll re-open this if we decide to go forward with this approach.

@arjan-bal arjan-bal closed this Sep 3, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants