Skip to content

xdsdepmgr: add functionality for cluster subscription - #8792

Merged
eshitachandwani merged 28 commits into
grpc:masterfrom
eshitachandwani:change1
Feb 5, 2026
Merged

eshitachandwani merged 28 commits into
grpc:masterfrom
eshitachandwani:change1

Conversation

@eshitachandwani

@eshitachandwani eshitachandwani commented Dec 26, 2025

Copy link
Copy Markdown
Member

Part of A74 changes.
This PR adds the functions to subscribe to clusters which increases the refcount and to unsubscribe to the cluster which decreases the refcount. These functions will be used in a later PR to start cluster watches for dynamic clusters. Will also be used by xds_resolver to make sure PRCs subscribe to clusters they are routed to and that the watches for those clusters remain active.
RELEASE NOTES: None

@eshitachandwani eshitachandwani added this to the 1.79 Release milestone Dec 26, 2025
@eshitachandwani eshitachandwani added Type: Internal Cleanup Refactors, etc Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Dec 26, 2025
@codecov

codecov Bot commented Dec 26, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.81159% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.15%. Comparing base (572fdca) to head (8ef8677).
⚠️ Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
internal/xds/xdsdepmgr/xds_dependency_manager.go 75.40% 11 Missing and 4 partials ⚠️
internal/xds/resolver/xds_resolver.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8792      +/-   ##
==========================================
- Coverage   83.31%   83.15%   -0.16%     
==========================================
  Files         414      414              
  Lines       32753    32805      +52     
==========================================
- Hits        27288    27279       -9     
- Misses       4064     4103      +39     
- Partials     1401     1423      +22     
Files with missing lines Coverage Δ
internal/xds/resolver/xds_resolver.go 88.70% <87.50%> (-0.06%) ⬇️
internal/xds/xdsdepmgr/xds_dependency_manager.go 80.04% <75.40%> (-0.38%) ⬇️

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread internal/xds/resolver/xds_resolver.go Outdated
Comment thread internal/xds/resolver/xds_resolver.go Outdated
Comment thread internal/xds/resolver/xds_resolver_test.go Outdated
Comment thread internal/xds/resolver/xds_resolver_test.go Outdated
Comment thread internal/xds/resolver/xds_resolver_test.go Outdated
Comment thread internal/xds/resolver/xds_resolver_test.go Outdated
Comment thread internal/xds/resolver/xds_resolver_test.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/resolver/xds_resolver.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/resolver/xds_resolver_test.go Outdated
Comment thread internal/xds/resolver/xds_resolver_test.go Outdated
Comment thread internal/xds/resolver/xds_resolver_test.go Outdated
Comment thread internal/xds/resolver/xds_resolver_test.go Outdated
@eshitachandwani

Copy link
Copy Markdown
Member Author

@eshitachandwani Please update the PR description as per our offline discussion.

Done.

@easwars easwars assigned eshitachandwani and unassigned easwars Jan 31, 2026
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager.go
@easwars easwars assigned eshitachandwani and unassigned easwars Feb 4, 2026
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager_test.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager_test.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager_test.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager_test.go Outdated
Comment thread internal/xds/xdsdepmgr/xds_dependency_manager_test.go Outdated
@easwars easwars assigned eshitachandwani and unassigned easwars Feb 5, 2026
@eshitachandwani
eshitachandwani merged commit 12fc393 into grpc:master Feb 5, 2026
14 checks passed
mbissa pushed a commit to mbissa/grpc-go that referenced this pull request Feb 10, 2026
Part of A74 changes.
This PR adds the functions to subscribe to clusters which increases the
refcount and to unsubscribe to the cluster which decreases the refcount.
These functions will be used in a later PR to start cluster watches for
dynamic clusters. Will also be used by xds_resolver to make sure PRCs
subscribe to clusters they are routed to and that the watches for those
clusters remain active.
RELEASE NOTES: None
mbissa pushed a commit to mbissa/grpc-go that referenced this pull request Feb 16, 2026
Part of A74 changes.
This PR adds the functions to subscribe to clusters which increases the
refcount and to unsubscribe to the cluster which decreases the refcount.
These functions will be used in a later PR to start cluster watches for
dynamic clusters. Will also be used by xds_resolver to make sure PRCs
subscribe to clusters they are routed to and that the watches for those
clusters remain active.
RELEASE NOTES: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Internal Cleanup Refactors, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants