A75: Add missing E2E test cases for xDS aggregate cluster - #9278
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9278 +/- ##
==========================================
- Coverage 87.53% 87.53% -0.01%
==========================================
Files 429 430 +1
Lines 30642 30678 +36
==========================================
+ Hits 26824 26853 +29
- Misses 3818 3824 +6
- Partials 0 1 +1 🚀 New features to boost your workflow:
|
Pranjali-2501
left a comment
Pranjali-2501
left a comment
Contributor
There was a problem hiding this comment.
Hi @mswierq , This PR mostly looks good. Have some minor comments, PTAL.
Pranjali-2501
approved these changes
Aug 31, 2026
easwars
reviewed
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add end-to-end test cases for xDS aggregate clusters:
TestAggregateCluster_LRS): Verifies that when an aggregate cluster (Root -> [PrimaryEDS, SecondaryEDS]) has LRS enabled on both leaf clusters, load is initially reported only for the primary cluster, and dynamically shifts to the secondary cluster upon primary failover.TestTelemetryLabels_AggregateCluster): Verifies that CSM telemetry labels from CDS cluster metadata reflect the active leaf cluster receiving traffic and switch to the secondary cluster's labels when failing over.This PR is part of A75 implementation. However, these test cases work for both the legacy and new LB policy tree.
RELEASE NOTES: n/a