Skip to content

cherry-pick #9365 to v1.83.x - #9366

Merged
eshitachandwani merged 2 commits into
grpc:v1.83.xfrom
eshitachandwani:cpv1.83
Aug 25, 2026
Merged

cherry-pick #9365 to v1.83.x#9366
eshitachandwani merged 2 commits into
grpc:v1.83.xfrom
eshitachandwani:cpv1.83

Conversation

@eshitachandwani

@eshitachandwani eshitachandwani commented Aug 25, 2026

Copy link
Copy Markdown
Member

Original PR : #9365

RELEASE NOTES:

  • server: Reject requests missing both :authority and Host headers with HTTP 400 and status Internal

…9365)

Fixes : grpc#9354

This PR updates the HTTP/2 transport layer to reject requests missing
both :authority and Host headers early. Also adds a defensive check in
xds server to ensure authority header is present.

RELEASE NOTES: 
- server: Reject requests missing both `:authority` and `Host` headers
with HTTP 400 and status `Internal`

---------

Co-authored-by: Madan Kumar <winklemad@outlook.com>
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.55%. Comparing base (a3e952d) to head (66d4fc1).

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.83.x    #9366      +/-   ##
===========================================
+ Coverage    87.53%   87.55%   +0.02%     
===========================================
  Files          421      421              
  Lines        29278    29284       +6     
===========================================
+ Hits         25628    25641      +13     
+ Misses        3650     3643       -7     
Files with missing lines Coverage Δ
internal/transport/http2_server.go 93.27% <100.00%> (+0.15%) ⬆️
internal/xds/server/routing.go 91.54% <100.00%> (+0.24%) ⬆️
test/servertester.go 75.00% <100.00%> (+0.17%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eshitachandwani
eshitachandwani merged commit 8668b69 into grpc:v1.83.x Aug 25, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants