Skip to content

cherry-pick #9346 to v1.84.x - #9372

Merged
eshitachandwani merged 1 commit into
grpc:v1.84.xfrom
eshitachandwani:cpvstatssfix1.84
Aug 25, 2026
Merged

cherry-pick #9346 to v1.84.x#9372
eshitachandwani merged 1 commit into
grpc:v1.84.xfrom
eshitachandwani:cpvstatssfix1.84

Conversation

@eshitachandwani

Copy link
Copy Markdown
Member

Original PR : #9346

RELEASE NOTES: None

… tests (grpc#9346)

Tests in `stats/opentelemetry` and `stats/opentelemetry/csm` asserted a
hardcoded compressed message size of `57` bytes for a 10,000-byte zero
payload with gzip compression.
In Go 1.27, standard library `compress/gzip` compression improvements
changed the output size of this payload from 57 bytes to 54 bytes,
causing metric and trace size assertions to fail when executed under
newer Go toolchains.

Added `GzipCompressedMessageSize` helper in to compute the expected
compressed byte length dynamically via `compress/gzip`. Updated metric
and trace assertions to use the same.

RELEASE NOTES: None
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.44%. Comparing base (8a9f866) to head (ff65499).

Files with missing lines Patch % Lines
...tats/opentelemetry/internal/testutils/testutils.go 72.72% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.84.x    #9372      +/-   ##
===========================================
+ Coverage    83.11%   87.44%   +4.33%     
===========================================
  Files          423      423              
  Lines        35272    30249    -5023     
===========================================
- Hits         29316    26451    -2865     
+ Misses        4442     3798     -644     
+ Partials      1514        0    -1514     
Files with missing lines Coverage Δ
...tats/opentelemetry/internal/testutils/testutils.go 97.03% <72.72%> (+1.65%) ⬆️

... and 422 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eshitachandwani eshitachandwani changed the title cherry-pick #9346 to v1.83.x cherry-pick #9346 to v1.84.x Aug 25, 2026

@mbissa mbissa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshitachandwani
eshitachandwani merged commit 89d55e0 into grpc:v1.84.x Aug 25, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants