Skip to content

grpc: remove unused callInfo field - #9397

Merged
arjan-bal merged 1 commit into
grpc:masterfrom
arjan-bal:remove-call-opts-unused-field
Sep 8, 2026
Merged

grpc: remove unused callInfo field#9397
arjan-bal merged 1 commit into
grpc:masterfrom
arjan-bal:remove-call-opts-unused-field

Conversation

@arjan-bal

Copy link
Copy Markdown
Contributor

Remove unused "on RPC commit" callbacks from callInfo. Callers of OnFinish call option type-assert and invoke the closure directly.

RELEASE NOTES: N/A

@arjan-bal arjan-bal added this to the 1.85 Release milestone Sep 4, 2026
@arjan-bal arjan-bal added Type: Internal Cleanup Refactors, etc Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. labels Sep 4, 2026
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.52%. Comparing base (93e31b4) to head (2f860ff).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9397      +/-   ##
==========================================
+ Coverage   87.47%   87.52%   +0.05%     
==========================================
  Files         425      429       +4     
  Lines       30303    30641     +338     
==========================================
+ Hits        26508    26820     +312     
- Misses       3794     3820      +26     
  Partials        1        1              
Files with missing lines Coverage Δ
rpc_util.go 87.01% <ø> (-0.05%) ⬇️

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal
arjan-bal merged commit 5c58cee into grpc:master Sep 8, 2026
22 checks passed
@arjan-bal
arjan-bal deleted the remove-call-opts-unused-field branch September 8, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. Type: Internal Cleanup Refactors, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants