Skip to content

ci: derive VS Code extension version from release tag - #133

Open
diofeher wants to merge 1 commit into
mainfrom
fix/release-vsce-version
Open

ci: derive VS Code extension version from release tag#133
diofeher wants to merge 1 commit into
mainfrom
fix/release-vsce-version

Conversation

@diofeher

Copy link
Copy Markdown
Contributor

Summary

  • The release workflow failed on the Publish to Marketplace step because package.json was pinned to 0.0.1, which already exists in the marketplace (failed run).
  • Rewrite the extension version from the release tag (v1.2.31.2.3) before packaging, so each tagged release publishes a unique version without needing a manual package.json bump per release.
  • Left a TODO comment flagging that the committed package.json version is intentionally stale; long-term we should keep it in sync (e.g. bump on the release PR) rather than derive it from the tag.

Test plan

  • Cut a test tag (or re-run the failed workflow) and confirm each *.vsix is packaged with the tag version.
  • Confirm Publish to Marketplace succeeds for all six vsce_target matrix entries.
  • Confirm workflow_dispatch runs (no tag) still package successfully using the in-tree version.

@diofeher
diofeher requested a review from yhakbar as a code owner April 18, 2026 12:10
@coderabbitai

coderabbitai Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@diofeher has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 28 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 94d59af9-3a6c-46a7-9073-042f2d467905

📥 Commits

Reviewing files that changed from the base of the PR and between d152cc8 and c7e872a.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-vsce-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@diofeher

Copy link
Copy Markdown
Contributor Author

This is just a workaround to not fail the publishing because we forgot to bump the package.json. Long-term a automated solution should be built

@diofeher diofeher self-assigned this Apr 18, 2026
@diofeher
diofeher force-pushed the fix/release-vsce-version branch 2 times, most recently from 75390ce to b1f987c Compare April 27, 2026 12:22
The marketplace rejects re-publishing an existing version, so the
release job was failing because package.json was pinned to 0.0.1.
Rewrite the version from the git tag before packaging so each tagged
release publishes a unique version.
@diofeher
diofeher force-pushed the fix/release-vsce-version branch from b1f987c to c7e872a Compare April 27, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant