chore: Updated cloud-nuke config to remove dynamodb tables - #4531
Conversation
📝 WalkthroughWalkthroughThe changes update the cloud-nuke configuration and GitHub Actions workflow to include DynamoDB tables as a target resource for cleanup. A new configuration section for DynamoDB is added, and the workflow command is updated to nuke DynamoDB tables matching specific naming patterns. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant cloud-nuke
participant AWS
GitHub Actions->>cloud-nuke: Run with resource types (s3, vpc, ec2, dynamodb)
cloud-nuke->>AWS: List and identify resources matching config (incl. DynamoDB tables)
cloud-nuke->>AWS: Delete matching S3, VPC, EC2, and DynamoDB resources
AWS-->>cloud-nuke: Return deletion status
cloud-nuke-->>GitHub Actions: Report results
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/cloud-nuke/config.yml (1)
18-21: Consider adding an explicit timeout for DynamoDB deletionsDynamoDB table deletion can exceed the default cloud-nuke timeout (10 m). Aligning with the S3 section’s
timeout: 1havoids premature failures in heavily-provisioned test accounts.dynamodb: + timeout: 1h include: table_names_regex: - "^terragrunt-test.*"
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/cloud-nuke/config.yml(1 hunks).github/workflows/cloud-nuke.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Pull Request has non-contributor approval
- GitHub Check: Test (macos)
🔇 Additional comments (2)
.github/cloud-nuke/config.yml (1)
18-21: Verify theregexkey in .github/cloud-nuke/config.ymlThe
include.table_names_regexfield may be misspelled—some cloud-nuke versions expecttable_name_regex(singular). A typo here will cause the include block to be ignored and all DynamoDB tables older than the global threshold to be wiped.• File: .github/cloud-nuke/config.yml (lines 18–21)
• Current snippet:dynamodb: include: table_names_regex: - "^terragrunt-test.*"Please confirm against your pinned cloud-nuke version (v0.40.0) by running locally:
cloud-nuke help dynamodb | grep -i regex -A2or consult the official cloud-nuke documentation to ensure you’re using the correct key.
.github/workflows/cloud-nuke.yml (1)
46-46: Resource-type added—ensure IAM role hasdynamodb:DeleteTableThe assumed role (
${{ secrets.CLOUD_NUKE_ROLE }}) must now allowdynamodb:DeleteTable,dynamodb:DescribeTable, anddynamodb:UpdateTable(for TTL disable). Without these, the step will error out or leave tables orphaned.
3 participants
Description
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide
Summary by CodeRabbit