fix: Preventing parse errors in stack generation in worktrees

[yhakbar]

Description

Right now, users with negations in their filter expressions aren't preventing reading parsing from happening in worktrees during stack generation. This is because we aren't properly propagating the non-Git filters from the parent discovery down to child discoveries.

This fix this by properly propagating the non-Git filters from the parent discovery down to child discoveries.

Relates to recommended approach for handling #5821

TODOs

Read the Gruntwork contribution guidelines.

• I authored this code entirely myself
• I am submitting code based on open source software (e.g. MIT, MPL-2.0, Apache)]
• I am adding or upgrading a dependency or adapted code and confirm it has a compatible open source license
• Update the docs.
• Run the relevant tests successfully, including pre-commit checks.
• Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

Summary by CodeRabbit

• Bug Fixes
  • Filter exclusions are now properly applied during worktree-based filtering operations.
  • Negated filters are now applied consistently in sub-discovery operations.
  • Improved stability by preventing parse errors from excluded catalog units.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
terragrunt-docs	Ready	Preview, Comment	Apr 9, 2026 7:21pm

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b4dc8051-de1d-446d-93c1-740e29ffd467

📥 Commits

Reviewing files that changed from the base of the PR and between 9b8da9b and 5664cc9.

📒 Files selected for processing (6)

• docs/src/data/changelog/v1.0.1.mdx
• internal/discovery/phase_worktree.go
• internal/discovery/phase_worktree_integration_test.go
• internal/filter/filters.go
• internal/filter/filters_test.go
• internal/stacks/generate/generate.go

---

📝 Walkthrough

Walkthrough

Filter exclusions, including negated filters from configuration and command-line arguments, are now propagated into git worktree sub-discoveries used for git-based filtering modes. Previously excluded catalog units inside worktrees are no longer discovered, preventing parse errors caused by missing stack generation context.

Changes

Cohort / File(s)	Summary
Documentation docs/src/data/changelog/v1.0.1.mdx	Added changelog entry documenting filter exclusion propagation into worktree sub-discoveries and the elimination of parse/evaluation errors for excluded units.
Worktree Discovery Logic internal/discovery/phase_worktree.go	Modified discoverInWorktree to concatenate parent discovery filters with existing filters; updated walkChangedStack to use non-git filters from parent discovery instead of empty filter set for both fromDiscovery and toDiscovery sub-discoveries.
Filter Core internal/filter/filters.go	Added ExcludingGitFilters() method to remove filters containing git expressions; refactored RestrictToStacks() logic; repositioned internal helper functions for clearer code organization.
Filter Tests internal/filter/filters_test.go	Added comprehensive test suite TestFilters_ExcludingGitFilters covering empty filters, git-only filters, non-git filters, mixed scenarios, and mutation validation.
Worktree Integration Tests internal/discovery/phase_worktree_integration_test.go	Added three integration tests validating negated filter application in worktree sub-discoveries, exclusion of land-mine units via git filters, and stack discovery without parsing non-stack units.
Stack Generation internal/stacks/generate/generate.go	Refactored discoverStacks to accept a readFiles bool flag instead of additional filters; updated worktreeStacksToGenerate to conditionally enable file-reading parsing for worktree discovery.

Sequence Diagram(s)

sequenceDiagram
    participant Parent as Parent Discovery
    participant Filter as Filter Component
    participant Worktree as Worktree Sub-Discovery
    participant Parser as Unit Parser
    
    Parent->>Filter: Collect all filters (including negations)
    Parent->>Filter: Extract non-git filters via ExcludingGitFilters()
    Filter-->>Parent: Return non-git filters
    Parent->>Worktree: Pass concatenated filters<br/>(parent non-git + worktree-specific)
    Worktree->>Worktree: Apply combined filters to units
    alt Unit matches negation filter
        Worktree-->>Parser: Skip unit (excluded)
    else Unit passes filters
        Worktree->>Parser: Process unit
        Parser-->>Worktree: Return parsed unit
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 46.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: preventing parse errors in stack generation within worktrees by propagating filters.
Description check	✅ Passed	The description follows the template structure with relevant sections filled out, though release notes placeholder text remains generic.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/fixing-dependency-resolution-in-stacks

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[denis256]

containsGitExpression and collectWorktreeExpressions share a lot of the same logic - can be room for deduplication