Skip to content

chore: Expanding lll coverage to tflint - #5866

Merged
yhakbar merged 1 commit into
mainfrom
chore/expanding-lll-coverage-to-tflint
Apr 29, 2026
Merged

chore: Expanding lll coverage to tflint#5866
yhakbar merged 1 commit into
mainfrom
chore/expanding-lll-coverage-to-tflint

Conversation

@yhakbar

@yhakbar yhakbar commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Addressed lll findings in tflint.

TODOs

Read the Gruntwork contribution guidelines.

  • I authored this code entirely myself
  • I am submitting code based on open source software (e.g. MIT, MPL-2.0, Apache)
  • I am adding or upgrading a dependency or adapted code and confirm it has a compatible open source license
  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated lll linter coverage to include tflint.

Summary by CodeRabbit

  • Chores
    • Updated internal code formatting standards and linter configuration to maintain consistent code quality.

@vercel

vercel Bot commented Apr 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
terragrunt-docs Ready Ready Preview, Comment Apr 29, 2026 5:09pm

Request Review

@coderabbitai

coderabbitai Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request includes a linter configuration update to exclude an additional directory from line length checks and reformatting of function signatures and debug calls in the tflint module. No functional logic changes were made.

Changes

Cohort / File(s) Summary
Linter Configuration
.golangci.yml
Updated the lll linter's path-except exclusion regex to additionally exempt files under internal/tflint/ from the line length check.
Code Formatting
internal/tflint/tflint.go
Reformatted function signatures and debug logging calls from single-line to multi-line format; rewrapped doc comment for improved readability. No control flow or runtime logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately captures the main change: expanding lll linter coverage to the tflint module by modifying exclusion patterns.
Description check ✅ Passed The description adequately explains the changes and includes most required template sections with appropriate checkmarks, though it lacks a 'Fixes' reference.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/expanding-lll-coverage-to-tflint

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@yhakbar
yhakbar force-pushed the chore/expanding-lll-coverage-to-runner-creds branch from 72c7a75 to 5dbade0 Compare April 24, 2026 18:27
@yhakbar
yhakbar force-pushed the chore/expanding-lll-coverage-to-tflint branch from b595fe0 to 0d7d132 Compare April 24, 2026 18:28
@yhakbar
yhakbar marked this pull request as ready for review April 24, 2026 18:29
@yhakbar
yhakbar requested a review from denis256 as a code owner April 24, 2026 18:29
denis256
denis256 previously approved these changes Apr 29, 2026
@yhakbar
yhakbar force-pushed the chore/expanding-lll-coverage-to-runner-creds branch from 5dbade0 to 4ea88ae Compare April 29, 2026 16:55
Base automatically changed from chore/expanding-lll-coverage-to-runner-creds to main April 29, 2026 17:02
@yhakbar
yhakbar dismissed denis256’s stale review April 29, 2026 17:02

The base branch was changed.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@internal/tflint/tflint.go`:
- Around line 245-247: Update the doc comment for findTflintConfigInProject to
correct the possessive typo: replace "it's" with "its" in the sentence "When
running from cache, we start searching from the original config directory to
find config in the source directory." so the comment reads "its parents" instead
of "it's parents" to fix the grammar in the public-facing comment.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fc1628d0-d7c6-404d-83c2-aeb9d5af0bfb

📥 Commits

Reviewing files that changed from the base of the PR and between 1efbff9 and 2451cb4.

📒 Files selected for processing (2)
  • .golangci.yml
  • internal/tflint/tflint.go

Comment thread internal/tflint/tflint.go
Comment on lines +245 to +247
// findTflintConfigInProject looks for a .tflint.hcl file in the current
// folder or it's parents. When running from cache, we start searching
// from the original config directory to find config in the source directory.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix doc comment grammar in Line 246 (it'sits).

Small typo in a public-facing comment within the changed block.

✏️ Proposed fix
-// folder or it's parents. When running from cache, we start searching
+// folder or its parents. When running from cache, we start searching
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// findTflintConfigInProject looks for a .tflint.hcl file in the current
// folder or it's parents. When running from cache, we start searching
// from the original config directory to find config in the source directory.
// findTflintConfigInProject looks for a .tflint.hcl file in the current
// folder or its parents. When running from cache, we start searching
// from the original config directory to find config in the source directory.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@internal/tflint/tflint.go` around lines 245 - 247, Update the doc comment for
findTflintConfigInProject to correct the possessive typo: replace "it's" with
"its" in the sentence "When running from cache, we start searching from the
original config directory to find config in the source directory." so the
comment reads "its parents" instead of "it's parents" to fix the grammar in the
public-facing comment.

@yhakbar
yhakbar merged commit d27064f into main Apr 29, 2026
28 of 29 checks passed
@yhakbar
yhakbar deleted the chore/expanding-lll-coverage-to-tflint branch April 29, 2026 17:18
Rahul-Kumar-prog pushed a commit to Rahul-Kumar-prog/terragrunt that referenced this pull request May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants