Skip to content

chore: Expanding lll coverage to runcfg - #5871

Merged
yhakbar merged 1 commit into
mainfrom
chore/expanding-lll-coverage-to-runcfg
May 7, 2026
Merged

chore: Expanding lll coverage to runcfg#5871
yhakbar merged 1 commit into
mainfrom
chore/expanding-lll-coverage-to-runcfg

Conversation

@yhakbar

@yhakbar yhakbar commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Addressed lll findings in runcfg.

TODOs

Read the Gruntwork contribution guidelines.

  • I authored this code entirely myself
  • I am submitting code based on open source software (e.g. MIT, MPL-2.0, Apache)
  • I am adding or upgrading a dependency or adapted code and confirm it has a compatible open source license
  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated lll linter coverage to include runcfg.

Summary by CodeRabbit

  • Style

    • Improved formatting consistency in function signatures and error messages across internal modules.
  • Chores

    • Updated linter configuration to refine code quality checks for specific paths.

@vercel

vercel Bot commented Apr 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
terragrunt-docs Ready Ready Preview, Comment May 7, 2026 8:05pm

Request Review

@coderabbitai

coderabbitai Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8e11117e-33ab-418f-92f1-e9fb08ab054f

📥 Commits

Reviewing files that changed from the base of the PR and between 1ccf394 and b98b323.

📒 Files selected for processing (2)
  • .golangci.yml
  • internal/runner/runcfg/util.go

📝 Walkthrough

Walkthrough

This PR updates Go linter configuration to exclude internal/runner/runcfg from line-length checks, then reformats code in util.go using multi-line function signatures, string concatenations, and validation error construction with no behavioral changes.

Changes

Linter Configuration and Code Formatting

Layer / File(s) Summary
Linter Configuration
.golangci.yml
The lll linter exclusion pattern expands path-except to include internal/runner/runcfg subpath, enabling longer lines in that directory.
Code Formatting
internal/runner/runcfg/util.go
Function signatures (CopyLockFile, GetTerraformSourceURL) are reformatted across multiple lines; error message construction in InvalidSourceURLWithMapError.Error() and ParsingModulePathError.Error() is split into multi-part string concatenations; validation error construction for ErrorsConfig (MaxAttempts, SleepIntervalSec) uses multi-line errors.Errorf format; clarifying comment added to GetModulePathFromSourceURL. All changes are cosmetic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • gruntwork-io/terragrunt#5853: Both PRs modify the .golangci.yml linter lll path-except pattern to adjust which internal/runner subpaths are excluded from line-length checks.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: expanding lll linter coverage to include the runcfg package, which aligns with the file modifications shown in the summary.
Description check ✅ Passed The description includes a clear summary and a TODO checklist, though it differs from the template with modified items and missing some original sections like issue reference.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/expanding-lll-coverage-to-runcfg

Comment @coderabbitai help to get the list of available commands and usage tips.

@yhakbar
yhakbar force-pushed the chore/expanding-lll-coverage-to-scaffold branch from 0ee5ae6 to 81d8bef Compare April 29, 2026 19:37
@yhakbar
yhakbar force-pushed the chore/expanding-lll-coverage-to-runcfg branch from ca9fdfa to ebf4934 Compare April 29, 2026 19:38
@yhakbar
yhakbar marked this pull request as ready for review April 29, 2026 20:17
@yhakbar
yhakbar requested a review from denis256 as a code owner April 29, 2026 20:17
denis256
denis256 previously approved these changes May 7, 2026
@yhakbar
yhakbar force-pushed the chore/expanding-lll-coverage-to-scaffold branch 2 times, most recently from 8b2a56d to 333c486 Compare May 7, 2026 19:52
Base automatically changed from chore/expanding-lll-coverage-to-scaffold to main May 7, 2026 20:02
@yhakbar
yhakbar dismissed denis256’s stale review May 7, 2026 20:02

The base branch was changed.

@yhakbar
yhakbar force-pushed the chore/expanding-lll-coverage-to-runcfg branch from ebf4934 to b98b323 Compare May 7, 2026 20:04
@yhakbar
yhakbar merged commit adca279 into main May 7, 2026
29 checks passed
@yhakbar
yhakbar deleted the chore/expanding-lll-coverage-to-runcfg branch May 7, 2026 20:19
Rahul-Kumar-prog pushed a commit to Rahul-Kumar-prog/terragrunt that referenced this pull request May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants