Skip to content

chore: Adding synctest rule - #5997

Closed
yhakbar wants to merge 3 commits into
mainfrom
chore/adding-synctest-rule
Closed

chore: Adding synctest rule#5997
yhakbar wants to merge 3 commits into
mainfrom
chore/adding-synctest-rule

Conversation

@yhakbar

@yhakbar yhakbar commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Description

Tried adding an experimental custom analyzer to the codebase to catch undesirable usage of time.Sleep without synctest.

Not sure it's a good idea, but it's worth taking a look at.

TODOs

Read the Gruntwork contribution guidelines.

  • I authored this code entirely myself
  • I am submitting code based on open source software (e.g. MIT, MPL-2.0, Apache)
  • I am adding or upgrading a dependency or adapted code and confirm it has a compatible open source license
  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@vercel

vercel Bot commented Apr 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
terragrunt-docs Ready Ready Preview, Comment Apr 29, 2026 2:29pm

Request Review

@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 04f54080-70aa-412d-b7fb-3ae1cb56bed8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/adding-synctest-rule

Comment @coderabbitai help to get the list of available commands and usage tips.

@yhakbar yhakbar closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant