Skip to content

fix: Dropping references to ctrl-\+j in the catalog key bindings - #6007

Merged
yhakbar merged 1 commit into
mainfrom
chore/remove-ctrl-j-binding
May 1, 2026
Merged

fix: Dropping references to ctrl-\+j in the catalog key bindings#6007
yhakbar merged 1 commit into
mainfrom
chore/remove-ctrl-j-binding

Conversation

@yhakbar

@yhakbar yhakbar commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

Description

Drops references to ctrl-/+j bindings in the catalog UI. It's not likely anyone is using this over enter.

TODOs

Read the Gruntwork contribution guidelines.

  • I authored this code entirely myself
  • I am submitting code based on open source software (e.g. MIT, MPL-2.0, Apache)
  • I am adding or upgrading a dependency or adapted code and confirm it has a compatible open source license
  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

Summary by CodeRabbit

  • Changes
    • Updated keyboard shortcuts for selection operations to use the enter key exclusively.
    • Adjusted available keyboard combinations for list filtering actions.
    • Updated help text to reflect the new keyboard bindings.

@vercel

vercel Bot commented Apr 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
terragrunt-docs Ready Ready Preview, Comment Apr 30, 2026 6:41pm

Request Review

@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c91fb97d-40f2-4ea3-a7bf-ff33033bc594

📥 Commits

Reviewing files that changed from the base of the PR and between 45fe7da and ac047e4.

📒 Files selected for processing (1)
  • internal/cli/commands/catalog/tui/keys.go

📝 Walkthrough

Walkthrough

Updates keyboard keymaps in the TUI by removing ctrl-j as a trigger for Choose actions in delegate and pager keymaps and from AcceptWhileFiltering keys, while updating associated help labels accordingly.

Changes

Cohort / File(s) Summary
Keyboard Keymaps
internal/cli/commands/catalog/tui/keys.go
Removes ctrl-j from Choose action triggers in delegate and pager keymaps (leaving only enter), removes ctrl-j from AcceptWhileFiltering filter keys, and updates corresponding help labels.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description follows the template structure with the main sections present, though the Release Notes section is incomplete and not filled out as required. Complete the Release Notes section with a specific one-line description of what was removed (e.g., 'Removed ctrl-j keyboard binding support from catalog UI') instead of the template placeholder.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing ctrl-j references from catalog key bindings, which matches the changeset perfectly.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-ctrl-j-binding

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@yhakbar
yhakbar marked this pull request as ready for review April 30, 2026 21:42
@yhakbar
yhakbar requested a review from denis256 as a code owner April 30, 2026 21:42
@yhakbar
yhakbar merged commit ecff758 into main May 1, 2026
94 of 96 checks passed
@yhakbar
yhakbar deleted the chore/remove-ctrl-j-binding branch May 1, 2026 19:53
Rahul-Kumar-prog pushed a commit to Rahul-Kumar-prog/terragrunt that referenced this pull request May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants