chore: Completing venv abstraction - #6698
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYour included review limit has been reached. You’re in a promotional period — use the checkbox below to run this review for free:
On-demand reviews are free for the next 31 days. After that, they cost $0.25 per reviewed file. How can I continue?Run this review now using the option above, or comment You can also wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (230)
Comment |
ebc681c to
fa26f11
Compare
fa26f11 to
212b1e3
Compare
212b1e3 to
acdceb8
Compare
acdceb8 to
43d7595
Compare
596e949 to
e3dd6dd
Compare
547fa3e to
fd01602
Compare
fd01602 to
e2accda
Compare
e2accda to
56ca70a
Compare
56ca70a to
64a4498
Compare
64a4498 to
150afd2
Compare
150afd2 to
d83007b
Compare
d83007b to
75ad3a7
Compare
75ad3a7 to
b9f447a
Compare
b9f447a to
f19b22e
Compare
f19b22e to
cc7acf3
Compare
cc7acf3 to
e117eb4
Compare
e117eb4 to
f665ea5
Compare
🤞🏽 Should complete the venv abstraction 🤞🏽. Closes some gaps related to GOOS and GOARCH usage. Also closes direct homedir access. Closes more gaps from direct filesystem and exec usage. Also adds some optimization for listing files in a directory with a particular suffix... Then I added one more optimization in `getTerraformInputNamesFromAutomaticVarFiles`. Addressing `EOF` in input stream. Dropping `iofs` aliases. Using TLS server for engine download tests. As a consequence, we can do a bit more parallelization in tests. Also renames `vfs.ReadDirEntries` to `vfs.ReadDir`. This ended up fixing an unexpected bug in how sops resolved credentials with the `--auth-provider-cmd` active. It would allow ambient environment variables have precedence over the values that would be set by the `--auth-provider-cmd`, which is inconsistent with how everything else works. That has been fixed.
f665ea5 to
a723728
Compare
Description
🤞🏽 Should complete the venv abstraction 🤞🏽.
Closes some gaps related to GOOS and GOARCH usage. Also closes direct homedir access.
Closes more gaps from direct filesystem and exec usage.
TODOs
Read the Gruntwork contribution guidelines.