fix: autoinclude config path fixes - #6711
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughDependency decoding retries with dependency labels overridden by sibling autoincludes skipped during failed expansion. Tests cover unresolved values paths, mixed dependencies, and stack generation. A changelog entry documents the fix. ChangesAutoinclude dependency override
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This PR improves autoinclude handling for config-path overrides and adds targeted regression and integration coverage; no actionable merge-blocking risk remains beyond normal checks and review. Sequence Diagram(s)sequenceDiagram
participant ConfigDecoder
participant DependencyRetry
participant AutoInclude
participant HCLExpansion
ConfigDecoder->>DependencyRetry: Decode dependencies
DependencyRetry->>HCLExpansion: Expand dependency blocks
HCLExpansion-->>DependencyRetry: Report unresolved values path
DependencyRetry->>AutoInclude: Read overridden dependency labels
AutoInclude-->>DependencyRetry: Return labels
DependencyRetry->>HCLExpansion: Retry while skipping labels
HCLExpansion-->>ConfigDecoder: Return decoded dependencies
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Fixes #6692.
TODOs
Read the Gruntwork contribution guidelines.
Summary by CodeRabbit