fix: Use the appropriate absolute path to unit config file, not basename when checking version constraints - #6728
Conversation
…ame when checking version constraints
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe version constraint checker is now exported. It parses unparsed units using ChangesUnit version constraint validation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This is a localized correction to use the unit configuration file's absolute path when checking version constraints, with associated tests; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Description
We use the base name right now, which will under-match. We should be using the full absolute path
TODOs
Read the Gruntwork contribution guidelines.
Summary by CodeRabbit