Remove deprecated symbols (delete wrappers)

[james00012]

Part 2 of removing the v1 deprecated API in v2 (staged migrate-then-delete). Stacked on #1869.

Deletes the ~1200 // Deprecated: function wrappers now that #1869 moved every internal caller to the Context variants. Because the callers are already migrated, this is a near-pure removal (-10.6k lines).

Also handles the non-wrapper cases:

• Promotes the 3 aws error types where the deprecated name held the real struct and the canonical name was an alias (IPForEc2InstanceNotFound, ParameterForDBInstanceNotFound, OptionGroupOptionSettingForDBInstanceNotFound).
• Trims the deprecated methods from the gcp InstanceGroup interface, keeping GetInstanceIDsContextE.

Verified: all 16 submodules + root build and test-compile (unmasked, -gcflags=-e) with no deprecated function symbols remaining.

Not in this PR:

• A few field/const/interface-level deprecations (grouped var specs in aws/ami.go, struct fields in helm/options.go, comments in k8s/tunnel.go) that are not top-level decls.
• core/v2/collections (separate: needs generic Intersection/Subtract helpers).

Summary by CodeRabbit

• Breaking Changes
  • Removed deprecated context-free helpers and aliases across AWS, Azure, GCP, Kubernetes, Docker, Terraform, Terragrunt, Helm, SSH, and utility modules.
  • Callers must use the corresponding context-aware APIs, enabling explicit cancellation and timeout control.
  • Removed legacy naming variants and compatibility fields; use the standardized names instead.
• Bug Fixes
  • Improved workspace deletion sequencing and storage-bucket existence checks.
  • Corrected several exported error and identifier names.
• Documentation
  • Updated API comments and removed obsolete guidance.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b1622e42-b51e-49d1-8281-0e9b0a22ebec

📥 Commits

Reviewing files that changed from the base of the PR and between c5f289d and 8896a36.

📒 Files selected for processing (149)

• modules/aws/account.go
• modules/aws/acm.go
• modules/aws/ami.go
• modules/aws/asg.go
• modules/aws/auth.go
• modules/aws/cloudwatch.go
• modules/aws/dynamodb.go
• modules/aws/ebs.go
• modules/aws/ec2-files.go
• modules/aws/ec2-syslog.go
• modules/aws/ec2.go
• modules/aws/ecr.go
• modules/aws/ecs.go
• modules/aws/errors.go
• modules/aws/iam.go
• modules/aws/keypair.go
• modules/aws/kms.go
• modules/aws/lambda.go
• modules/aws/rds.go
• modules/aws/region.go
• modules/aws/route53.go
• modules/aws/s3.go
• modules/aws/secretsmanager.go
• modules/aws/sns.go
• modules/aws/sqs.go
• modules/aws/ssm.go
• modules/aws/vpc.go
• modules/azure/actiongroup.go
• modules/azure/aks.go
• modules/azure/appService.go
• modules/azure/availabilityset.go
• modules/azure/client_factory.go
• modules/azure/compute.go
• modules/azure/container_apps.go
• modules/azure/containers.go
• modules/azure/cosmosdb.go
• modules/azure/datafactory.go
• modules/azure/disk.go
• modules/azure/frontdoor.go
• modules/azure/keyvault.go
• modules/azure/loadbalancer.go
• modules/azure/loganalytics.go
• modules/azure/monitor.go
• modules/azure/mysql.go
• modules/azure/networkinterface.go
• modules/azure/nsg.go
• modules/azure/postgresql.go
• modules/azure/publicaddress.go
• modules/azure/recoveryservices.go
• modules/azure/region.go
• modules/azure/resourcegroup.go
• modules/azure/sql.go
• modules/azure/sql_managedinstance.go
• modules/azure/storage.go
• modules/azure/subscription.go
• modules/azure/synapse.go
• modules/azure/virtualnetwork.go
• modules/core/logger/logger.go
• modules/core/logger/parser/integration_test.go
• modules/core/random/random.go
• modules/core/retry/retry.go
• modules/core/shell/command.go
• modules/database/database.go
• modules/dnshelper/dnshelper.go
• modules/docker/build.go
• modules/docker/docker_compose.go
• modules/docker/images.go
• modules/docker/inspect.go
• modules/docker/push.go
• modules/docker/run.go
• modules/docker/stop.go
• modules/gcp/cloudbuild.go
• modules/gcp/compute.go
• modules/gcp/gcr.go
• modules/gcp/oslogin.go
• modules/gcp/pubsub.go
• modules/gcp/region.go
• modules/gcp/storage.go
• modules/helm/cmd.go
• modules/helm/delete.go
• modules/helm/format.go
• modules/helm/install.go
• modules/helm/options.go
• modules/helm/repo.go
• modules/helm/rollback.go
• modules/helm/template.go
• modules/helm/upgrade.go
• modules/httphelper/continuous.go
• modules/httphelper/dummy_server.go
• modules/httphelper/httphelper.go
• modules/k8s/client.go
• modules/k8s/cluster_role.go
• modules/k8s/config.go
• modules/k8s/configmap.go
• modules/k8s/cronjob.go
• modules/k8s/daemonset.go
• modules/k8s/deployment.go
• modules/k8s/event.go
• modules/k8s/ingress.go
• modules/k8s/job.go
• modules/k8s/kubectl.go
• modules/k8s/namespace.go
• modules/k8s/networkpolicy.go
• modules/k8s/node.go
• modules/k8s/persistent_volume.go
• modules/k8s/persistent_volume_claim.go
• modules/k8s/pod.go
• modules/k8s/replicaset.go
• modules/k8s/role.go
• modules/k8s/secret.go
• modules/k8s/self_subject_access_review.go
• modules/k8s/service.go
• modules/k8s/service_account.go
• modules/k8s/tunnel.go
• modules/k8s/version.go
• modules/packer/packer.go
• modules/ssh/agent.go
• modules/ssh/session.go
• modules/ssh/ssh.go
• modules/terraform/apply.go
• modules/terraform/cmd.go
• modules/terraform/destroy.go
• modules/terraform/get.go
• modules/terraform/init.go
• modules/terraform/opa_check.go
• modules/terraform/output.go
• modules/terraform/plan.go
• modules/terraform/show.go
• modules/terraform/validate.go
• modules/terraform/var-file.go
• modules/terraform/workspace.go
• modules/terragrunt/apply.go
• modules/terragrunt/destroy.go
• modules/terragrunt/format.go
• modules/terragrunt/graph.go
• modules/terragrunt/hcl_validate.go
• modules/terragrunt/init.go
• modules/terragrunt/output.go
• modules/terragrunt/plan.go
• modules/terragrunt/render.go
• modules/terragrunt/run.go
• modules/terragrunt/run_all.go
• modules/terragrunt/stack_clean.go
• modules/terragrunt/stack_generate.go
• modules/terragrunt/stack_output.go
• modules/terragrunt/stack_run.go
• modules/terragrunt/validate.go
• modules/teststructure/save_test_data.go
• modules/teststructure/teststructure.go

---

Walkthrough

This change removes deprecated context-free helper APIs across cloud, container, infrastructure, database, and utility modules. Context-aware variants remain as the supported entry points, with selected naming, error-type, and helper-flow updates.

Changes

Context-aware API cleanup

Layer / File(s)	Summary
Deprecated wrapper removal modules/aws/*, modules/azure/*, modules/gcp/*, modules/k8s/*, modules/terraform/*, modules/terragrunt/*	Removes non-context and E wrappers that used context.Background(), leaving context-based APIs.
Public naming and contract updates modules/aws/errors.go, modules/aws/rds.go, modules/gcp/compute.go, modules/helm/options.go, modules/ssh/*, modules/teststructure/*	Replaces deprecated aliases, normalizes exported error/type names, tightens an interface, and removes deprecated option fields and constants.
Context-flow and implementation adjustments modules/aws/s3.go, modules/azure/*, modules/gcp/storage.go, modules/helm/*, modules/terraform/*, modules/terragrunt/*	Updates selected storage, parsing, command, workspace, client-construction, and context-wrapper flows while retaining the context-based implementations.

Estimated code review effort: 5 (Critical) | ~120 minutes

Possibly related PRs

• gruntwork-io/terratest#1869: Migrates callers from deprecated AWS wrappers to the context-based APIs retained by this change.

Suggested reviewers: yhakbar, denis256

Poem

Old wrappers fade, contexts lead,
APIs trimmed to what we need.
Clouds and clusters march in line,
With cancellation by design.
Fewer aliases, cleaner flight—
The codebase packs a lighter kite.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch james/terratest-v2-deprecation-remove

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}