docs: record the symbol moves and behaviour changes from the v2 beta - #1882
Conversation
v2-import-map.md is the artifact people migrate from, and it covered import paths only. It was also marked FROZEN without qualification, which reads as 'this is the whole migration'. It is not: #1877 moved eight functions between modules, and #1878 and #1879 changed two behaviours. Add a relocation table, a note on what deliberately stayed in teststructure and why the churn is small, a qualifier swap recipe with the two cases where a blind find and replace goes wrong, and a section on the ExternalIP preference and the RestConfig serialization error. Rescope the FROZEN note to import paths. Every symbol in the table was checked against the merged code.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe import map documents resolved Terratest v2 package renames, relocated functions, unchanged symbols, qualifier handling, node lookup behavior, and ChangesTerratest v2 migration documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #1875. There is no v2 migration doc, and
v2-import-map.mdcovers import paths only.Gap
The map is marked FROZEN without qualification, which reads as "this is the whole migration". It is not. A user who runs the documented path rewrite gets clean imports and then eight compile errors, with nothing pointing at where those symbols went.
Change
Three additions to
docs/v2-import-map.md:teststructurefunctions that moved toaws,k8s,packerandsshin refactor(teststructure): drop aws, k8s, packer and ssh dependencies #1877, plus what deliberately stayed and why the churn is about 6% of call sites.awsto the AWS SDK and alias Terratest's.ExternalIPpreference from refactor(k8s): resolve node public IPs through an injectable lookup #1878 including the newFindNodeHostnameWithOptionsContext[E], and theRestConfigserialization error from fix(k8s): refuse to serialize KubectlOptions carrying a RestConfig #1879.FROZEN is rescoped to import paths.
Every symbol in the table was checked against the merged code.
Summary by CodeRabbit