Skip to content

docs: record the symbol moves and behaviour changes from the v2 beta - #1882

Merged
james00012 merged 5 commits into
mainfrom
docs/v2-symbol-relocations
Aug 10, 2026
Merged

docs: record the symbol moves and behaviour changes from the v2 beta#1882
james00012 merged 5 commits into
mainfrom
docs/v2-symbol-relocations

Conversation

@james00012

@james00012 james00012 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #1875. There is no v2 migration doc, and v2-import-map.md covers import paths only.

Gap

The map is marked FROZEN without qualification, which reads as "this is the whole migration". It is not. A user who runs the documented path rewrite gets clean imports and then eight compile errors, with nothing pointing at where those symbols went.

Change

Three additions to docs/v2-import-map.md:

FROZEN is rescoped to import paths.

Every symbol in the table was checked against the merged code.

Summary by CodeRabbit

  • Documentation
    • Updated the v2 import map to mark renamed packages as resolved and link beta symbol relocations.
    • Added migration guidance for moved functions, unchanged symbols, and qualifier or import updates.
    • Documented node address selection, including preference for external IP addresses.
    • Clarified options-aware node lookup behavior.
    • Documented serialization errors that may occur when using REST configuration with Kubernetes options.

v2-import-map.md is the artifact people migrate from, and it covered import
paths only. It was also marked FROZEN without qualification, which reads as
'this is the whole migration'. It is not: #1877 moved eight functions
between modules, and #1878 and #1879 changed two behaviours.

Add a relocation table, a note on what deliberately stayed in teststructure
and why the churn is small, a qualifier swap recipe with the two cases where
a blind find and replace goes wrong, and a section on the ExternalIP
preference and the RestConfig serialization error. Rescope the FROZEN note
to import paths.

Every symbol in the table was checked against the merged code.
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d4befe2-39ad-41fc-a94b-d667c2bbd21f

📥 Commits

Reviewing files that changed from the base of the PR and between 18eb952 and 06962b8.

📒 Files selected for processing (1)
  • docs/v2-import-map.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/v2-import-map.md

Walkthrough

The import map documents resolved Terratest v2 package renames, relocated functions, unchanged symbols, qualifier handling, node lookup behavior, and KubectlOptions serialization errors.

Changes

Terratest v2 migration documentation

Layer / File(s) Summary
Import and symbol migration
docs/v2-import-map.md
The import map records three resolved package renames and documents eight relocated functions, unchanged symbols, and qualifier handling.
Beta behavior guidance
docs/v2-import-map.md
The guide documents ExternalIP node lookup behavior, options-aware lookup functions, and KubectlOptions.MarshalJSON errors for RestConfig.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: denis256, yhakbar

Poem

Imports move to version two,
Symbols settle where they’re due.
Nodes choose ExternalIP with care,
Serialization errors make issues clear.
The migration map keeps changes in view.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the documentation change for v2 beta symbol moves and behavior changes.
Description check ✅ Passed The description clearly explains the gap, documents the changes, and states that the symbols were checked against merged code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/v2-symbol-relocations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@james00012
james00012 marked this pull request as ready for review August 7, 2026 02:59
@james00012
james00012 enabled auto-merge (squash) August 10, 2026 12:53
@james00012
james00012 merged commit 8d9266a into main Aug 10, 2026
17 checks passed
@james00012
james00012 deleted the docs/v2-symbol-relocations branch August 10, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants