Refactor Cache Logic#446
Open
emilyliublair wants to merge 1 commit intoemily/finalize_submit_ratings_flowfrom
Open
Refactor Cache Logic#446emilyliublair wants to merge 1 commit intoemily/finalize_submit_ratings_flowfrom
emilyliublair wants to merge 1 commit intoemily/finalize_submit_ratings_flowfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #[ticket-number]
Added a generic cache manager utility in src/utils to handle all localStorage read/write operations. Used this cache manager in Course.ts to replace repetitive code and verified no breaking changes. Had to update GPA cache key since the GPA cache item was modified to fit the generic cache entry interface.
How to Test
All metrics (GPA, ratings, professor ratings) are still able to be fetched:
Verified that ratings caches are still invalidated upon submission of new rating