Skip to content

Replace guava dependency with java.nio APIs#300

Merged
emdash-ie merged 3 commits into
mainfrom
update/guava-33.6.0-jre
Jul 21, 2026
Merged

Replace guava dependency with java.nio APIs#300
emdash-ie merged 3 commits into
mainfrom
update/guava-33.6.0-jre

Conversation

@gu-scala-steward-private-repos

@gu-scala-steward-private-repos gu-scala-steward-private-repos Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

About this PR

📦 Updates com.google.guava:guava from 19.0 to 33.6.0-jre

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version number

The following files still refer to the old version number (19.0).
You might want to review and update them manually.

benchmarks/src/main/resources/massive-contents-list.json
⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.google.guava", artifactId = "guava" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.guava", artifactId = "guava" }
}]
labels: dependencies

@emdash-ie

Copy link
Copy Markdown
Contributor

Rather than updating Guava, I think we should remove it. We only use it in tests to load files, which is a minimal use of what I think is a large dependency: it should be straightforward to use Java standard library code instead, like the thrift round-trip tests do.

Before now, the guavaVersion variable was used for one dependency on
guava, but not for a second dependency. This commit changes the second
dependency to also use the same variable, although I’m not actually sure
how important it is that they be in sync.
Our dependency on guava was only being used to read files in tests: such
a minor usecase doesn’t merit an external dependency when we can do the
same with standard Java APIs. This commit removes guava and replaces
uses of it with uses of java.nio APIs.
@emdash-ie emdash-ie changed the title Update guava to 33.6.0-jre Replace guava dependency with java.nio APIs Jul 21, 2026
@emdash-ie
emdash-ie merged commit 01f1a35 into main Jul 21, 2026
5 checks passed
@emdash-ie
emdash-ie deleted the update/guava-33.6.0-jre branch July 21, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant