Add translation search highlights#785
Draft
philmcmahon wants to merge 8 commits into
Draft
Conversation
philmcmahon
force-pushed
the
add-highlights
branch
from
July 21, 2026 10:13
43482f2 to
fe7ff54
Compare
philmcmahon
force-pushed
the
add-highlights
branch
from
July 22, 2026 08:33
efc9c9c to
4c03e5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR wires in the various bits and pieces needed to show highlights for search results from inside translated text.
As part of this work I've ended up abandoning the dropdown switcher for viewing translations introduced in #780 and instead made the translation views just more tabs in the bottom right. I think the UX here could use some work (as you can get a lot of tabs) but didn't want to put time into dealing with highlights and url query syncing for the translation viewer as part of this bit of work, instead putting it off for some future UX overhaul (hopefully post full typescriptification).
Depends on #783 which should be merged and rebased into this before this is reviewed - it was too awkward working with a js PreviewSwitcher.
The main changes:
languageData.text.translationfieldHow has this change been tested?