Add components for different states of the API response#1001
Open
lindseydew wants to merge 8 commits into
Open
Add components for different states of the API response#1001lindseydew wants to merge 8 commits into
lindseydew wants to merge 8 commits into
Conversation
Base automatically changed from
ld-switches-configuration
to
vb-ld/add-saved-article-routing-behind-switch
February 21, 2023 10:18
vlbee
reviewed
Feb 22, 2023
| saveForLaterAPICall: () => Promise<unknown>; | ||
| } | ||
|
|
||
| export function SavedArticlesPage(props: SavedArticlesPageProps) { |
Member
There was a problem hiding this comment.
Wonder if it's worth looking at the AsyncLoader utility used by the AccountOverview? There seem to be two async loaders in use in this repo - useAsyncLoader hook and the AsyncLoader class compononent. I would check with the rest of the MMA team which component is preferred and see if we can align our work with that.
Author
There was a problem hiding this comment.
Yeah good shout, I think from our discussion yesterday we think hooks is the right approach?
lindseydew
force-pushed
the
ld-display-saved-articles
branch
from
February 23, 2023 09:40
5a4f462 to
bed6733
Compare
lindseydew
changed the title
lindseydew
marked this pull request as ready for review
February 23, 2023 09:41
vlbee
force-pushed
the
vb-ld/add-saved-article-routing-behind-switch
branch
from
March 1, 2023 11:37
2a75263 to
dda4adf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds the basic components we'll need for rendering the Save for Later page. Since this feature is behind a switch, this is intended as a work in progress to give us the files we need to start iterating on the project. We still need to flesh out what the API request and response will be, which is why this is just testing mocking a call to an external service for now.
How to test
We should check that there is no visibility of these pages in PROD as is it behind a switch.
How can we measure success?
Have we considered potential risks?
Images
Accessibility