point help centre at fastly#1713
Open
johnduffell wants to merge 7 commits into
Open
Conversation
# Conflicts: # cdk/lib/help-centre.ts
johnduffell
commented
Jul 21, 2026
| domainName, | ||
| resourceRecord, | ||
| ttl: Duration.minutes(5), | ||
| ttl: Duration.hours(1), |
Member
Author
There was a problem hiding this comment.
not sure what a reasonable value is - I'm sure up to a week would also make sense given it's just a CNAME?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following on from #1710
Do not merge until the domain is validated in salesforce for PROD.
This PR changes from the special CNAME record needed for validation, over to the real fastly one.
This means that real traffic will use fastly rather than hitting a dead end.
Tested in CODE and it's worked