Add optional title field to Topic case class on /device/register endpoint#1525
Merged
Conversation
Contributor
Member
Author
|
We are awaiting confirmation from iOS and Android that this change is OK |
Reettaphant
added
maintenance
michaelclapham
approved these changes
Nov 17, 2025
michaelclapham
left a comment
michaelclapham
left a comment
Member
There was a problem hiding this comment.
Tested multiple times on Android and seems to be fine now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds an optional title
Option[String]field on topic that defaults toNoneAdds a controller spec for the non-legacy `/device/register' endpoint to give visibility on the functionality.
iOS are migrating from the legacy to the new endpoint. They send a title field on each topic in the request and have asked that this data does not get lost in the response. The field in NOT persisted in the database. The field is optional as android does not use this field.
This will have no impact on the DB as what gets upserted is an amalgamation of the required type and name fields.
How to test
/device/registerHow can we measure success?
Have we considered potential risks?
Images
Accessibility