Move to use only one central cdk directory by JuliaBrigitte · Pull Request #1556 · guardian/mobile-n10n

JuliaBrigitte · 2025-11-20T11:12:28Z

What does this change?

Moved contents of extra cdk directory in notificationworkerlambda into the main cdk directory.

Positive effects of this are

following best practice
import libraries only once
maintain versions in one directory only (part of the work meant using the newer version used in one of the two joined directories)

How to test

In the cdk directory run with with mobile credential to check the changes that were introduced:

npm run diff SenderWorkerStack-CODE -- --profile mobile

Snapshots stay the same
(There is one difference, the gu:cdk:version in the senderworker.test.ts.snap snapshot is now TEST)

We checked the changes to cloudformation and they correspond only to a version bump.

Cloudformation changeset json


Stack SenderWorkerStack-CODE (notification-sender-workers-cdk-CODE)
Metadata
[~] Metadata gu:cdk:version: 61.5.0 to 61.11.1

Conditions
[-] Condition CDKMetadataAvailable: {"Fn::Or":[{"Fn::Or":[{"Fn::Equals":[{"Ref":"AWS::Region"},"af-south-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"ap-east-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"ap-northeast-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"ap-northeast-2"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"ap-northeast-3"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"ap-south-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"ap-south-2"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"ap-southeast-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"ap-southeast-2"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"ap-southeast-3"]}]},{"Fn::Or":[{"Fn::Equals":[{"Ref":"AWS::Region"},"ap-southeast-4"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"ca-central-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"ca-west-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"cn-north-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"cn-northwest-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"eu-central-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"eu-central-2"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"eu-north-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"eu-south-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"eu-south-2"]}]},{"Fn::Or":[{"Fn::Equals":[{"Ref":"AWS::Region"},"eu-west-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"eu-west-2"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"eu-west-3"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"il-central-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"me-central-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"me-south-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"sa-east-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"us-east-1"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"us-east-2"]},{"Fn::Equals":[{"Ref":"AWS::Region"},"us-west-1"]}]},{"Fn::Equals":[{"Ref":"AWS::Region"},"us-west-2"]}]}

Resources
[~] AWS::SQS::Queue ios/SenderDlq iosSenderDlqE2E2925D
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios/SenderDlq/Resource"}
[~] AWS::SQS::Queue ios/SenderSqs iosSenderSqsA94CB0A0
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios/SenderSqs/Resource"}
[~] AWS::IAM::Role ios/ExecutionRole iosExecutionRoleEE25DF12
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios/ExecutionRole/Resource"}
[~] AWS::Lambda::Function ios/SenderLambdaCtr iosSenderLambdaCtr6053C1F8
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios/SenderLambdaCtr/Resource"}
[~] AWS::Lambda::EventSourceMapping ios/SenderSqsEventSourceMapping iosSenderSqsEventSourceMapping2E507F40
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios/SenderSqsEventSourceMapping/Resource"}
[~] AWS::CloudWatch::Alarm ios/SenderThrottleAlarm iosSenderThrottleAlarmFCACC1F8
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios/SenderThrottleAlarm/Resource"}
[~] AWS::CloudWatch::Alarm ios/SenderErrorAlarm iosSenderErrorAlarmAD88F28E
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios/SenderErrorAlarm/Resource"}
[~] AWS::CloudWatch::Alarm ios/SenderTooFewInvocationsAlarm iosSenderTooFewInvocationsAlarm14117FE9
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios/SenderTooFewInvocationsAlarm/Resource"}
[~] AWS::CloudWatch::Alarm ios/SenderTooFewNonBreakingAlarm iosSenderTooFewNonBreakingAlarmC2075137
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios/SenderTooFewNonBreakingAlarm/Resource"}
[~] AWS::CloudWatch::Alarm ios/SenderTooFewBreakingNewsAlarm iosSenderTooFewBreakingNewsAlarm870D69CB
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios/SenderTooFewBreakingNewsAlarm/Resource"}
[~] AWS::SSM::Parameter ios/SenderQueueSSMParameter iosSenderQueueSSMParameter921EF0C9
 ├─ [~] Tags
 │   └─ [~] .gu:cdk:version:
 │       ├─ [-] 61.5.0
 │       └─ [+] 61.11.1
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios/SenderQueueSSMParameter/Resource"}
[~] AWS::SQS::Queue android/SenderDlq androidSenderDlqB74778CC
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android/SenderDlq/Resource"}
[~] AWS::SQS::Queue android/SenderSqs androidSenderSqsCF269D3F
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android/SenderSqs/Resource"}
[~] AWS::IAM::Role android/ExecutionRole androidExecutionRole81D14062
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android/ExecutionRole/Resource"}
[~] AWS::Lambda::Function android/SenderLambdaCtr androidSenderLambdaCtr85CB623B
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android/SenderLambdaCtr/Resource"}
[~] AWS::Lambda::EventSourceMapping android/SenderSqsEventSourceMapping androidSenderSqsEventSourceMapping29E8124B
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android/SenderSqsEventSourceMapping/Resource"}
[~] AWS::CloudWatch::Alarm android/SenderThrottleAlarm androidSenderThrottleAlarmE6E5BEC7
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android/SenderThrottleAlarm/Resource"}
[~] AWS::CloudWatch::Alarm android/SenderErrorAlarm androidSenderErrorAlarmC6FC169C
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android/SenderErrorAlarm/Resource"}
[~] AWS::CloudWatch::Alarm android/SenderTooFewInvocationsAlarm androidSenderTooFewInvocationsAlarmC306ECD5
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android/SenderTooFewInvocationsAlarm/Resource"}
[~] AWS::CloudWatch::Alarm android/SenderTooFewNonBreakingAlarm androidSenderTooFewNonBreakingAlarm35FD6EBB
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android/SenderTooFewNonBreakingAlarm/Resource"}
[~] AWS::CloudWatch::Alarm android/SenderTooFewBreakingNewsAlarm androidSenderTooFewBreakingNewsAlarmEE8C7099
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android/SenderTooFewBreakingNewsAlarm/Resource"}
[~] AWS::SSM::Parameter android/SenderQueueSSMParameter androidSenderQueueSSMParameter88F729D1
 ├─ [~] Tags
 │   └─ [~] .gu:cdk:version:
 │       ├─ [-] 61.5.0
 │       └─ [+] 61.11.1
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android/SenderQueueSSMParameter/Resource"}
[~] AWS::SQS::Queue ios-edition/SenderDlq ioseditionSenderDlq85139531
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios-edition/SenderDlq/Resource"}
[~] AWS::SQS::Queue ios-edition/SenderSqs ioseditionSenderSqsFDE339AC
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios-edition/SenderSqs/Resource"}
[~] AWS::IAM::Role ios-edition/ExecutionRole ioseditionExecutionRole61247F06
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios-edition/ExecutionRole/Resource"}
[~] AWS::Lambda::Function ios-edition/SenderLambdaCtr ioseditionSenderLambdaCtr2410D4D7
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios-edition/SenderLambdaCtr/Resource"}
[~] AWS::Lambda::EventSourceMapping ios-edition/SenderSqsEventSourceMapping ioseditionSenderSqsEventSourceMapping9B8EF143
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios-edition/SenderSqsEventSourceMapping/Resource"}
[~] AWS::CloudWatch::Alarm ios-edition/SenderThrottleAlarm ioseditionSenderThrottleAlarm3B81024B
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios-edition/SenderThrottleAlarm/Resource"}
[~] AWS::CloudWatch::Alarm ios-edition/SenderErrorAlarm ioseditionSenderErrorAlarm4CA6BA17
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios-edition/SenderErrorAlarm/Resource"}
[~] AWS::CloudWatch::Alarm ios-edition/SenderTooFewInvocationsAlarm ioseditionSenderTooFewInvocationsAlarmD32BB28C
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios-edition/SenderTooFewInvocationsAlarm/Resource"}
[~] AWS::SSM::Parameter ios-edition/SenderQueueSSMParameter ioseditionSenderQueueSSMParameter4EAB5876
 ├─ [~] Tags
 │   └─ [~] .gu:cdk:version:
 │       ├─ [-] 61.5.0
 │       └─ [+] 61.11.1
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/ios-edition/SenderQueueSSMParameter/Resource"}
[~] AWS::SQS::Queue android-edition/SenderDlq androideditionSenderDlqE5B23A41
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-edition/SenderDlq/Resource"}
[~] AWS::SQS::Queue android-edition/SenderSqs androideditionSenderSqs400C0F3A
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-edition/SenderSqs/Resource"}
[~] AWS::IAM::Role android-edition/ExecutionRole androideditionExecutionRoleDEF8ADAE
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-edition/ExecutionRole/Resource"}
[~] AWS::Lambda::Function android-edition/SenderLambdaCtr androideditionSenderLambdaCtrF0169D16
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-edition/SenderLambdaCtr/Resource"}
[~] AWS::Lambda::EventSourceMapping android-edition/SenderSqsEventSourceMapping androideditionSenderSqsEventSourceMapping87D2DEDF
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-edition/SenderSqsEventSourceMapping/Resource"}
[~] AWS::CloudWatch::Alarm android-edition/SenderThrottleAlarm androideditionSenderThrottleAlarmBE557A69
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-edition/SenderThrottleAlarm/Resource"}
[~] AWS::CloudWatch::Alarm android-edition/SenderErrorAlarm androideditionSenderErrorAlarmD6FB170B
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-edition/SenderErrorAlarm/Resource"}
[~] AWS::CloudWatch::Alarm android-edition/SenderTooFewInvocationsAlarm androideditionSenderTooFewInvocationsAlarmE4AB00FB
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-edition/SenderTooFewInvocationsAlarm/Resource"}
[~] AWS::SSM::Parameter android-edition/SenderQueueSSMParameter androideditionSenderQueueSSMParameterEC513AB5
 ├─ [~] Tags
 │   └─ [~] .gu:cdk:version:
 │       ├─ [-] 61.5.0
 │       └─ [+] 61.11.1
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-edition/SenderQueueSSMParameter/Resource"}
[~] AWS::SQS::Queue android-beta/SenderDlq androidbetaSenderDlqE9C306E1
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-beta/SenderDlq/Resource"}
[~] AWS::SQS::Queue android-beta/SenderSqs androidbetaSenderSqs57513D18
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-beta/SenderSqs/Resource"}
[~] AWS::IAM::Role android-beta/ExecutionRole androidbetaExecutionRoleFA113395
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-beta/ExecutionRole/Resource"}
[~] AWS::Lambda::Function android-beta/SenderLambdaCtr androidbetaSenderLambdaCtrB3CF7FC4
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-beta/SenderLambdaCtr/Resource"}
[~] AWS::Lambda::EventSourceMapping android-beta/SenderSqsEventSourceMapping androidbetaSenderSqsEventSourceMappingA8FE78C9
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-beta/SenderSqsEventSourceMapping/Resource"}
[~] AWS::CloudWatch::Alarm android-beta/SenderThrottleAlarm androidbetaSenderThrottleAlarmEA10B1A4
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-beta/SenderThrottleAlarm/Resource"}
[~] AWS::CloudWatch::Alarm android-beta/SenderErrorAlarm androidbetaSenderErrorAlarmE6FAB709
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-beta/SenderErrorAlarm/Resource"}
[~] AWS::CloudWatch::Alarm android-beta/SenderTooFewInvocationsAlarm androidbetaSenderTooFewInvocationsAlarm7B50CD4B
 ├─ [~] Tags
 │   └─ @@ -5,7 +5,7 @@
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:cdk:version",
 │      [-]   "Value": "61.5.0"
 │      [+]   "Value": "61.11.1"
 │      [ ] },
 │      [ ] {
 │      [ ]   "Key": "gu:repo",
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-beta/SenderTooFewInvocationsAlarm/Resource"}
[~] AWS::SSM::Parameter android-beta/SenderQueueSSMParameter androidbetaSenderQueueSSMParameterCEB2EE8F
 ├─ [~] Tags
 │   └─ [~] .gu:cdk:version:
 │       ├─ [-] 61.5.0
 │       └─ [+] 61.11.1
 └─ [-] Metadata
     └─ {"aws:cdk:path":"SenderWorkerStack-CODE/android-beta/SenderQueueSSMParameter/Resource"}

How can we measure success?

Everything works as before

github-actions · 2025-11-20T15:21:33Z

Deploy build 4707 of `mobile-n10n:slomonitor` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2025-11-20T15:21:54Z

Deploy build 4710 of `mobile-n10n:registration` to CODE

All deployment options

From guardian/actions-riff-raff.

akash1810

Not for this PR necessarily, but I think we could make further changes to the cdk directory to make it easier to work with:

Pinning each dependency to a specific version
Either using yarn OR npm. Currently a lockfile for each exists 😱.
Updating dependencies

JuliaBrigitte · 2025-11-21T14:06:20Z

Not for this PR necessarily, but I think we could make further changes to the cdk directory to make it easier to work with:

Pinning each dependency to a specific version

Either using yarn OR npm. Currently a lockfile for each exists 😱.

Updating dependencies

Created a card for this

github-actions · 2025-11-24T12:13:14Z

Deploy build 4615 of `mobile-n10n:schedule` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2025-11-24T12:13:16Z

Deploy build 4611 of `mobile-n10n:eventconsumer` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2025-11-24T12:13:27Z

Deploy build 4625 of `mobile-n10n:football` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2025-11-24T12:13:35Z

Deploy build 4625 of `mobile-n10n:fakebreakingnewslambda` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2025-11-24T12:13:35Z

Deploy build 4618 of `mobile-n10n:reportextractor` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2025-11-24T12:13:53Z

Deploy build 4621 of `mobile-n10n:report` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2025-11-24T12:14:02Z

Deploy build 4646 of `mobile-n10n:notification` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2025-11-24T12:15:53Z

Deploy build 5010 of `mobile-n10n:notificationworkerlambda` to CODE

All deployment options

From guardian/actions-riff-raff.

Awaiting MSS team's review.

akash1810

Changes to tag values only is as basically a no-op. Great work!

aracho1

Thank you for doing this! ✨

akash1810 · 2025-11-24T14:36:53Z

          },
        ],
-        "EvaluationPeriods": 48,
+        "EvaluationPeriods": 24,


This looks like a bad rebase as it's undone the changes from https://github.com/guardian/mobile-n10n/pull/1563/files? We could run a diff again to double check?

@akash1810 could you have one more look before I merge this? Thank you!

@akash1810 could you have one more look before I merge this? Thank you!

Let's run a cdk diff. If it only shows tag changes, we're good.

…o the main cdk directory

Co-authored-by: Akash <akash1810@users.noreply.github.com>

JuliaBrigitte force-pushed the jb/one-cdk-directory branch 3 times, most recently from 3d50a01 to eaa0735 Compare November 20, 2025 15:19

JuliaBrigitte force-pushed the jb/one-cdk-directory branch 2 times, most recently from 0e0c810 to 199d14c Compare November 20, 2025 17:41

akash1810 previously approved these changes Nov 21, 2025

View reviewed changes

Comment thread cdk/package.json Outdated

Comment thread cdk/package.json Outdated

JuliaBrigitte force-pushed the jb/one-cdk-directory branch from 577f414 to b57dc4b Compare November 21, 2025 14:02

akash1810 self-requested a review November 24, 2025 11:55

JuliaBrigitte force-pushed the jb/one-cdk-directory branch from b57dc4b to 0337784 Compare November 24, 2025 12:12

JuliaBrigitte marked this pull request as ready for review November 24, 2025 12:18

JuliaBrigitte requested a review from a team as a code owner November 24, 2025 12:18

akash1810 removed their request for review November 24, 2025 12:29

akash1810 approved these changes Nov 24, 2025

View reviewed changes

aracho1 approved these changes Nov 24, 2025

View reviewed changes

JuliaBrigitte force-pushed the jb/one-cdk-directory branch from 0337784 to 2772d11 Compare November 24, 2025 14:23

akash1810 reviewed Nov 24, 2025

View reviewed changes

JuliaBrigitte and others added 5 commits November 24, 2025 15:00

Moved contents of extra cdk directory in notificationworkerlambda int…

f08966c

…o the main cdk directory

Adjust directories paths

f6b9a94

Update dependabot.yml to only one cdk directory

a530e63

Add cloudformation stack name for use with diff

868a2fc

Co-authored-by: Akash <akash1810@users.noreply.github.com>

Pin @guardian/cdk version

a56df28

Co-authored-by: Akash <akash1810@users.noreply.github.com>

JuliaBrigitte force-pushed the jb/one-cdk-directory branch from 2772d11 to a56df28 Compare November 24, 2025 15:15

akash1810 mentioned this pull request Nov 25, 2025

chore: Use a single node package manager #1564

Merged

JuliaBrigitte merged commit bef27ad into main Nov 26, 2025
7 checks passed

JuliaBrigitte deleted the jb/one-cdk-directory branch November 26, 2025 13:11

akash1810 mentioned this pull request Jan 19, 2026

ci: Remove duplicate step #1628

Merged

Uh oh!

Conversation

JuliaBrigitte commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this change?

How to test

How can we measure success?

Uh oh!

github-actions Bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akash1810 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JuliaBrigitte commented Nov 21, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akash1810 left a comment

Choose a reason for hiding this comment

Uh oh!

aracho1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akash1810 Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JuliaBrigitte commented Nov 20, 2025 •

edited

Loading

github-actions Bot commented Nov 20, 2025 •

edited

Loading

github-actions Bot commented Nov 20, 2025 •

edited

Loading

github-actions Bot commented Nov 24, 2025 •

edited

Loading

akash1810 Nov 26, 2025 •

edited

Loading