Skip to content

chore(deps): Use @guardian/tsconfig#1566

Merged
akash1810 merged 1 commit into
mainfrom
aa/tsconfig
Nov 27, 2025
Merged

chore(deps): Use @guardian/tsconfig#1566
akash1810 merged 1 commit into
mainfrom
aa/tsconfig

Conversation

@akash1810

Copy link
Copy Markdown
Member

Note

Builds on #1565.

What does this change?

Use the departmental TypeScript configuration from @guardian/tsconfig.

How to test

CI passing should suffice. These changes are isolated to the cdk part of the repository; as the snapshot has not changed, the change can be viewed as a deployment no-op.

Use the departmental TypeScript configuration from `@guardian/tsconfig`.
@akash1810
akash1810 requested a review from a team as a code owner November 25, 2025 16:10
@akash1810 akash1810 added the dependencies Pull requests that update a dependency file label Nov 25, 2025
Base automatically changed from aa/eslint to main November 27, 2025 10:01

@aracho1 aracho1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we should the departmental ts config in general?

@akash1810
akash1810 merged commit 1cab266 into main Nov 27, 2025
3 checks passed
@akash1810
akash1810 deleted the aa/tsconfig branch November 27, 2025 10:05
@akash1810

Copy link
Copy Markdown
Member Author

Should we should the departmental ts config in general?

I'd recommend so, yes as its one less thing to think about. The departmental config can be extended with custom rules too if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants