Remove all legacy infrastructure for report - #1606
Merged
Merged
Conversation
jacobwinch
commented
Jan 5, 2026
| domainName: | ||
| | 'report.notifications.guardianapis.com' | ||
| | 'report.notifications.code.dev-guardianapis.com'; | ||
| // This maps to the DnsRecord resource in Route53; we can remove this complexity as part of the DNS switchover |
Contributor
Author
There was a problem hiding this comment.
This has been redundant since #1593; I should've really tidied it up in that PR.
jacobwinch
commented
Jan 5, 2026
| DomainName: | ||
| Type: String | ||
| Description: The domain name of the ELB, should contain the trailing dot stuff.zone.example.com. | ||
| Resources: |
Contributor
Author
There was a problem hiding this comment.
In this case I think we can delete this whole file. There are 8 resources:
DnsRecord(AWS::Route53::RecordSet) - this is no longer needed as the DNS is now all managed in NS1 via aGuCname(see Start managing report's NS1 CNAME via GuCDK #1591 for more details).InstanceSecurityGroup(AWS::EC2::SecurityGroup) - the pattern replaces this.LoadBalancerToPrivateASG(AWS::ElasticLoadBalancing::LoadBalancer) - the pattern replaces this with an ALB (v2 load balancer).LoadBalancerSecurityGroup(AWS::EC2::SecurityGroup) - the pattern replaces this.NotificationsReportInstanceProfile(AWS::IAM::InstanceProfile) - the pattern replaces this.NotificationsReportRole(AWS::IAM::Role) - the pattern replaces this.PrivateReportAutoscalingGroup(AWS::AutoScaling::AutoScalingGroup) - the pattern replaces this.ReportLaunchConfig(AWS::AutoScaling::LaunchConfiguration) - the pattern replaces this with a launch template.
And the stateful DynamoDB tables are defined in a separate file (and are therefore unaffected by deleting this one).
Contributor
Contributor
Contributor
Contributor
jacobwinch
force-pushed
the
jw-remove-legacy-infra
branch
from
January 7, 2026 14:18
df90a53 to
ebdc990
Compare
jacobwinch
force-pushed
the
jw-remove-legacy-infra
branch
from
January 7, 2026 14:26
ebdc990 to
e191aad
Compare
jacobwinch
marked this pull request as ready for review
January 7, 2026 14:54
aracho1
approved these changes
Jan 7, 2026
Contributor
Author
|
The notifications page in Ophan still looks correct; this confirms that the legacy infrastructure really was redundant.
Just confirming that this has been re-enabled now: 
|
akash1810
added a commit
that referenced
this pull request
Jan 13, 2026
The `VpcId` parameter was renamed to `GuCdkVpcId` to avoid conflicts with the YAML template. The YAML template has been removed in #1606, so the rename is no longer needed.
akash1810
added a commit
that referenced
this pull request
Jan 13, 2026
The `VpcId` parameter was renamed to `GuCdkVpcId` to avoid conflicts with the YAML template. The YAML template has been removed in #1606, so the rename is no longer needed.
akash1810
added a commit
that referenced
this pull request
Jan 13, 2026
The `VpcId` parameter was renamed to `GuCdkVpcId` to avoid conflicts with the YAML template. The YAML template has been removed in #1606, so the rename is no longer needed.
akash1810
added a commit
that referenced
this pull request
Jan 14, 2026
The `VpcId` parameter was renamed to `GuCdkVpcId` to avoid conflicts with the YAML template. The YAML template has been removed in #1606, so the rename is no longer needed.
akash1810
added a commit
that referenced
this pull request
Jan 15, 2026
The `VpcId` parameter was renamed to `GuCdkVpcId` to avoid conflicts with the YAML template. The YAML template has been removed in #1606, so the rename is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR completes the GuCDK migration of
report's compute infrastructure.It is a follow up to these related PRs (#1589, #1591, #1592, #1593).
How to test
I've tested the deployment steps listed below in
CODEto confirm that it works as expected (see successful Riff-Raff deployment of this branch).I've confirmed that the API continues working as expected after the legacy infrastructure has been removed.
How can we measure success?
We'll have removed legacy infrastucture, which completes the migration and reduces AWS costs (we have been paying for 2 sets of infrastructure since #1589 was deployed).
Have we considered potential risks?
Once this PR is merged rolling back the GuCDK migration is no longer a realistic option and we are committed to fixing forwards. Consequently I think we should wait a couple of days after the deployment of #1593 (this went out on Monday 5th January) before merging this change.
Deployment steps
PRODonly)Apptag on the old ASG (in order to bypass a Riff-Raff pre-flight check)mainusing Riff-Raff'sDangerousmode (in order to delete some protected resource types - a load balancer and a Route53 record). Deployment log.PRODonly)