ci: Test GH ruleset changes - #1629
Closed
akash1810 wants to merge 1 commit into
Closed
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tweaked the repository ruleset to require a passing status check from
build:The effect of this is all workflows with a
buildjob1 must pass before a PR can be merged tomain. Previously, the only requirement to merge was an approval. This should provide more confidence in changes.Depending on the name of a job is a bit fragile, however its better than nothing!
This PR demonstrates the effect of these changes. Attempts to install an invalid version of Scala Play results in a failing build:
Footnotes
Conditionally triggered, or otherwise. ↩