feat: Move Dynamo table to report CFN stack - #1668
Merged
Merged
Conversation
akash1810
force-pushed
the
aa/reports-table
branch
from
February 2, 2026 10:16
fd76f76 to
02fe866
Compare
Contributor
Contributor
Contributor
Contributor
Contributor
akash1810
changed the title
report CFN stackreport CFN stack
akash1810
changed the title
report CFN stackreport CFN stack
This change requires manual deployment using the CFN import feature.
The Dynamo table is now defined in this CFN stack, so we can reference it via its logical ID.
The single resource from this template has been migrated to `report.ts`.
akash1810
force-pushed
the
aa/reports-table
branch
from
February 24, 2026 10:57
02fe866 to
c7896db
Compare
Contributor
Contributor
Contributor
akash1810
marked this pull request as ready for review
February 24, 2026 11:14
akash1810
enabled auto-merge
February 24, 2026 11:17
jorgeazevedo
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Recommended to review commit by commit.
What does this change?
When looking at the architecture diagram, the
reportservices can be defined as everything to the right of Fastly. In #1616 and #1623 thereportextractorandeventconsumerLambdas were moved into the same CloudFormation stack as the EC2 app. This change moves the final piece - the Dynamo table.Deployment strategy
Warning
This change requires manual deployment following these steps. Consequently, once deployed, reversion would be tricky!
Riff-Raff does not currently support this type of CloudFormation operation, so we have to deploy manually, specifically:
DeletionPolicyto the Dynamo tablemobile-notifications-dynamo-CloudFormation stack, removing the Dynamo table from CloudFormationreportCloudFormation stack, importing the Dynamo tablereportCloudFormation stack, referring to the Dynamo table by logical IDThe last step can be done by Riff-Raff.
How to test?
One test would be to compare the definition of the Dynamo table between the removed YAML template and the CDK stack (at 5a68124). Running
yarn synth Report-PROD > after.yamlwill create a YAML template from the CDK definition. If we diff theAWS::DynamoDB::Tableresource in the two templates, we have:Other than properties moving position, the only change is to tagging.
How can we measure success?
All resources for the
reportservices are co-located in a single CloudFormation stack and thus are updated via CD (Riff-Raff) reducing the risk of human-error.