feat(registration): Bring second NS1 CNAME record into CloudFormation - #1669
Merged
Conversation
akash1810
commented
Feb 2, 2026
| * @see https://metrics.gutools.co.uk/goto/zF4xr1HvR?orgId=1 | ||
| */ | ||
| private addLegacyCname({ app, intermediateCname }: RegistrationProps) { | ||
| const route53Domain = this.parameters['DomainName']; |
Member
Author
There was a problem hiding this comment.
See
mobile-n10n/registration/conf/registration.yaml
Lines 75 to 77 in c2e01cb
Brings the second CNAME into CloudFormation to ease its removal at a later date; removal can be done via a standard CloudFormation update.
akash1810
force-pushed
the
aa/version-control-second-ns1-record
branch
from
February 2, 2026 12:37
18c8d6c to
e6b76c1
Compare
jacobwinch
approved these changes
Feb 2, 2026
Contributor
Contributor
Contributor
Contributor
Contributor
akash1810
commented
Feb 2, 2026
| * | ||
| * @see https://metrics.gutools.co.uk/goto/zF4xr1HvR?orgId=1 | ||
| */ | ||
| private addLegacyCname({ app, intermediateCname }: RegistrationProps) { |
Member
Author
There was a problem hiding this comment.
Not entirely convinced about this function name, however it is only temporary. Suggestions for a clearer name welcomed!
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Follows #1654 and brings the second CNAME into CloudFormation to ease its removal at a later date; removal can be done via a standard CloudFormation update.
How to test
This change adds a
Guardian::DNS::RecordSetresource to the CloudFormation stack; this resource type requires all properties to exactly match the current CNAME, therefore to the test is to confirm the DNS record details and deploy to CODE.