[DRAFT] Handle VAR reversals#1855
Draft
vlbee wants to merge 14 commits into
Draft
Conversation
Contributor
vlbee
commented
Jul 14, 2026
| case object DeleteChannelEvent extends LiveActivityEventType { val asString = "channel-delete" } | ||
|
|
||
| object LiveActivityEventType { | ||
| val values: Seq[LiveActivityEventType] = Seq( |
Contributor
Contributor
vlbee
commented
Jul 14, 2026
| case object CreateChannelEvent extends LiveActivityEventType { val asString = "channel-create" } | ||
| case object StartLiveActivityEvent extends LiveActivityEventType { val asString = "broadcast-start" } | ||
| case object UpdateLiveActivityEvent extends LiveActivityEventType { val asString = "broadcast-update" } | ||
| case object UpdateStateChangeLiveActivityEvent extends LiveActivityEventType { val asString = "broadcast-update" } |
Member
Author
There was a problem hiding this comment.
This is needed to be able to dedupe, but the string value should mean it's processed as a standard update event once pushed to eventbus to the live activities service.
Contributor
Contributor
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP PR and will be replaced by smaller sequential prs.
What does this change?
Introduction of VAR in football matches means key events such as a goal or red card can be reversed. This is not captured in the incoming PA data; the overruled event simply disappears from the match event timeline. In practice this means LiveActivities and updated Android push notifications display the wrong score until a subsequent "triggering event" emits a new update.
How has this change been tested?
How can we measure success?
Have we considered potential risks?
Images
Accessibility