Generate a payload for deleted match event goals#1860
Open
vlbee wants to merge 2 commits into
Open
Conversation
vlbee
force-pushed
the
var/test-deleted-flag
branch
from
July 22, 2026 12:37
dcfc3e3 to
b17b194
Compare
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
vlbee
commented
Jul 22, 2026
| topic = topics, | ||
| matchStatus = status, | ||
| eventId = UUID.nameUUIDFromBytes(triggeringEvent.eventId.getBytes).toString, | ||
| eventId = s"${triggeringEvent.eventId}/${triggeringEvent.isDeleted}", // used to derive the uuid in the payload trait |
Member
Author
There was a problem hiding this comment.
The payload UUID is derived from the trait Payload derivedId def here, so I don't think it's necessary to make a UUID from the event ID (which is either the PA eventID, or a UUID we already create once for synthetic events.)
vlbee
commented
Jul 22, 2026
| val catsVersion: String = "2.13.0" | ||
| val okHttpVersion: String = "4.12.0" | ||
| val paClientVersion: String = "7.0.12" | ||
| val paClientVersion: String = "7.0.18-PREVIEW.parse-deleted-event.2026-07-21T1518.accf3da8" |
Member
Author
There was a problem hiding this comment.
Use the proper release before merging.
vlbee
marked this pull request as ready for review
July 22, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PA has indicated they may be able to add a
deleted=trueattribute flag to reversed goals on the/match/eventsendpoint we use. More info here: guardian/pa-football-client#123What does this change?
This PR tests the Preview release of the
pa-football-clientlibrary.dervidedIdfor the payload UUID - this ensures that when the deleted flag changes, the same triggering event will have a unique UUID and NOT be filtered out by the event filter so we can send a follow up payload for a deleted event.TODO before release
pa-football-clientlibraryHow has this change been tested?
TODO
On unit tests, we can see the payload with unique UUID generated for a
deleted=truegoal at '37.Live Activities
Left:
deleted=falseRight:deleted=truePush Notifications
Left:
deleted=falseRight:deleted=trueHow can we measure success?
Have we considered potential risks?
Images
Accessibility