Skip to content

feat!: Remove sidebar once Composer uses its own.#254

Open
rhystmills wants to merge 1 commit into
mainfrom
rm/remove-sidebar
Open

feat!: Remove sidebar once Composer uses its own.#254
rhystmills wants to merge 1 commit into
mainfrom
rm/remove-sidebar

Conversation

@rhystmills

Copy link
Copy Markdown
Contributor

This PR removes sidebar code that has been moved to Composer.

Test locally with Composer using yalc, as specified in the readme. Does Typerighter function as expected in Composer?

@rhystmills rhystmills changed the title Remove sidebar once Composer uses its own. feat!: Remove sidebar once Composer uses its own. Aug 23, 2023
@simonbyford

Copy link
Copy Markdown
Contributor

Looks good!

I think you'll need to remove Sidebar.spec.tsx. If this spec has any value, I wonder if we should port it to flexible-content?

We'll also need to remove the call to createSidebarView from pages/index.ts (which seems to power https://guardian.github.io/prosemirror-typerighter/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants