hide deprecated tags#571
Open
dblatcher wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The
searchTagsmethod of the tagManager service will now exclude deprecated tags by default. This should be a no-op in production there are no deprecated Tags in the PROD tag DB (the UI does not expose the new property yet).The only usage of the tagManager to search for tags is to set the print location book section tag.
How has this change been tested?
Ran tagmanager locally on guardian/tagmanager#637 and marked the "Obs: 100 Great British Woods and Forests (nbs)" tag (https://tagmanager.local.dev-gutools.co.uk/hyper/tags/43543) as deprecated.
Opened the management tab of content drawer for an article and type "obs" into the Print location / book section search input.
On this branch, "Obs: 100 Great British Woods and Forests (nbs)" tag was no longer included in the results, but is included on main.
How can we measure success?
We will be able to deprecate historical book sections (like the observer related ones) so users only see the relevant options.
Have we considered potential risks?
This PR doesn't add a UI option for allowing the user to see deprecated tag, but that is unllikely to be required as workflow is not typcally used for historical content. If necessary, Composer could be used to restore deprecated section tags.
Images